Bug 59743 - log4cxx compile fails on errno
Bug#: 59743 Product:  Gentoo Linux Version: unspecified Platform: All
OS/Version: Linux Status: RESOLVED Severity: normal Priority: P2
Resolution: FIXED Assigned To: ka0ttic@gentoo.org Reported By: bencollins@tamu.edu
Component: Development
URL: 
Summary: log4cxx compile fails on errno
Keywords:  
Status Whiteboard: 
Opened: 2004-08-07 19:35 0000
Description:   Opened: 2004-08-07 19:35 0000 
An unwise #define causes errno.h to not be included when compiling on linux. 
Patch is attached.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

------- Comment #1 From Benjamin Collins 2004-08-07 19:38:19 0000 ------- 
Created an attachment (id=36997) [details]
patch for log4cxx-0.9.5

~/src/filewatchdog.cpp

------- Comment #2 From Benjamin Collins 2004-08-07 19:42:17 0000 ------- 
(From update of attachment 36997 [details])
>--- filewatchdog.cpp.orig	2004-08-07 21:36:34.987676584 -0500
>+++ filewatchdog.cpp	2004-08-07 21:36:41.562677032 -0500
>@@ -17,10 +17,7 @@
> #include <log4cxx/helpers/filewatchdog.h>
> #include <log4cxx/helpers/loglog.h>
> #include <sys/stat.h>
>-
>-#ifdef WIN32
>-#include <errno.h>
>+#include <cerrno>
>-#endif
> 
> using namespace log4cxx;
> using namespace log4cxx::helpers;

------- Comment #3 From Benjamin Collins 2004-08-07 20:18:51 0000 ------- 
Created an attachment (id=36998) [details]
patch #2 for log4cxx-0.9.5

------- Comment #4 From Bjarke Istrup Pedersen 2004-08-07 23:02:10 0000 ------- 
Compiles fine for me when using changed patch 1, and patch 2.
I have combined them into one, and corrected the path (added src/ before the filenames).
This obsoletes patch 1 and 2.

------- Comment #5 From Bjarke Istrup Pedersen 2004-08-07 23:02:54 0000 ------- 
Created an attachment (id=37000) [details]
combined patch

------- Comment #6 From Aaron Walker (RETIRED) 2004-12-26 05:54:54 0000 ------- 
Do you still run into this problem with 0.9.7?

------- Comment #7 From Aaron Walker (RETIRED) 2005-01-06 05:48:49 0000 ------- 
Fixed. Thanks guys.