Summary: | sys-apps/tuned - tuned.utils.commands: Executing /sbin/sysctl error: [Errno 2] No such file or directory | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | theShirbiny <shirbiny> |
Component: | Current packages | Assignee: | Yixun Lan <dlan> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | tuned-2.7.1-sysctl.patch |
Description
theShirbiny
2016-08-10 08:18:31 UTC
commit 8f17ed27906b9cd2deda507a2a1b6ab00b75eaab Author: Lars Wendler <polynomial-c@gentoo.org> Date: Wed Aug 10 10:52:30 2016 mail-client/claws-mail: Don't run python phases unconditionally. Fixing bug #590914. Refactored latest ebuild a bit. Package-Manager: portage-2.3.0 Signed-off-by: Lars Wendler <polynomial-c@gentoo.org> Ah sorry, wrong bug :-( ping Created attachment 445194 [details, diff]
tuned-2.7.1-sysctl.patch
Obviously we can change that path, but can we be sure sysctl will always be there?
sorry, this bug slip my list I've reported similar bug to upstream, they probably only tested on fedora system can we simply use "sysctl" instead of hard-coding the path? (In reply to Jeroen Roovers from comment #4) > Created attachment 445194 [details, diff] [details, diff] > tuned-2.7.1-sysctl.patch > > Obviously we can change that path, but can we be sure sysctl will always be > there? Can we do something like the below? distutils.spawn import find_executable sysctl = find_executable("sysctl") Hi, I am Tuned upstream, thanks for catching the problem. I think the proposed patch is OK, the /usr/sbin/ should probably work in the most cases. But maybe we could even go without the hardcoded path. Tuned needs root and if somebody could alter the PATH environment variable it's receiving or executables on that path, there would be probably more serious issues witch such system. Any opinions? Yes, I also prefer no hardcoded path better leave the permission controlling out of the package (the policy part) Fixed by following upstream commit: https://git.fedorahosted.org/cgit/tuned.git/commit/?id=a3c3471755be10615fb9df8b845a4353e220a84a closed this, thanks all! |