Bug 589598

Summary:	x11-libs/libxkbcommon should not depend on x11-proto/xproto x11-proto/kbproto
Product:	Gentoo Linux	Reporter:	dolphinling <aguertin+gentoo>
Component:	Current packages	Assignee:	Matt Turner <mattst88>
Status:	RESOLVED FIXED
Severity:	normal	CC:	x11
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	611056
Attachments:	libxkbcommon-0.6.1.ebuild

Description dolphinling 2016-07-24 13:34:44 UTC

x11-libs/libxkbcommon does not need dependencies on x11-proto/xproto or x11-proto/kbproto. They are not checked for in libxkbcommon's configure, and none of the headers they install are used by libxkbcommon.

This is true even when installed with USE="+X" (although in that case libxkbcommon depends on libxcb, which will bring in xproto).

Comment 1 dolphinling 2016-07-24 13:35:49 UTC

Created attachment 441448 [details]
libxkbcommon-0.6.1.ebuild

Comment 2 Matt Turner gentoo-dev

2017-01-29 21:54:08 UTC

Failed to configure for me without xproto/kbproto.

This works for you?

Comment 3 dolphinling 2017-01-30 10:29:57 UTC

Yes, this works for me. I even updated it to 0.7.1 (no changes needed) and it continues working.

What error do you get from configure?

Comment 4 dolphinling 2017-02-11 09:34:30 UTC

(forgot to take this off of needinfo when I responded)

Comment 5 Matt Turner gentoo-dev

2017-03-04 07:24:01 UTC

(In reply to dolphinling from comment #4)
> (forgot to take this off of needinfo when I responded)

Must have been a PEBKAC :)

You are right. Fixed by:

commit fc2569837710e0cc981421473b313d4fae71c326
Author: Matt Turner <mattst88@gentoo.org>
Date:   Fri Mar 3 23:10:46 2017 -0800

    x11-libs/libxkbcommon: Depend on xproto and kbproto only for USE=X