Summary: | dev-lang/perl-5.24.0-r1 random test failures due to MANIFEST changes ( Failed test MANIFEST sorted properly at porting/manifest.t ) | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Kent Fredric (IRC: kent\n) (RETIRED) <kentnl> |
Component: | Current packages | Assignee: | Gentoo Perl team <perl> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | gwendal |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
gentoo/patchlevel-manifest.diff
Compilation Failure when "patchlevel-gentoo.h is not in the manifest. |
Description
Kent Fredric (IRC: kent\n) (RETIRED)
2016-07-21 03:50:26 UTC
@Gwendal, adding you as CC on this issue as your name is on the original commit, so hopefully you can shed some light on this. commit 1ddfb9cc7eb204864bcf113b74ca4c5c9780c84a (HEAD -> master, origin/master, origin/HEAD) Author: Andreas K. Hüttel <dilfridge@gentoo.org> Date: Thu Dec 29 17:53:20 2016 +0100 dev-lang/perl: Restore MANIFEST sort order, bug 589302 Package-Manager: Portage-2.3.3, Repoman-2.3.1 dev-lang/perl/files/perl-patchlevel-manifest.patch | 10 ++++++++++ dev-lang/perl/perl-5.24.1_rc4.ebuild | 6 +++--- 2 files changed, 13 insertions(+), 3 deletions(-) Created attachment 457854 [details] Compilation Failure when "patchlevel-gentoo.h is not in the manifest. #1. Sorry, I missed the email. The patch intent is to add patchlevel-gentoo.h in MANIFEST: It was required for a following patch to [pseudo]cross-compile miniperl only (see https://chromium-review.googlesource.com/#/c/347748/) - note this patch is moot since perl 5.24 do support proper cross-compilation. If absent from MANIFEST, a file would not linked into the portage /work/perl-<>/host directory and compilation of miniperl would fail: >>> Configuring source in /build/samus/tmp/portage/dev-lang/perl-5.22.1-r1/work/perl-5.22.1 ... First let's make sure your kit is complete. Checking... Locating common programs... Checking compatibility between /bin/echo and builtin echo (if any)... Symbolic links are supported. Checking how to test for symbolic links... You can test for symbolic links with 'test -h'. Targetarch not defined. Targethost not defined. Building host miniperl and generate_uudmap binaries In file included from perl.c:34:0: patchlevel.h:140:31: fatal error: patchlevel-gentoo.h: No such file or directory #include "patchlevel-gentoo.h" ^ compilation terminated. [Full log enclosed.] I was not aware of the ordering requirement, I verified the new patch is working as well. Thanks Gwendal. Seems now we fixed the bug twice, so I reverted my last commit (and the header file name is also now configurable again). https://github.com/gentoo-perl/perl-patchset/commit/23179a630d04c3d40e7c09bccbf2f38f3ad72b93 commit 1d7266e35487144b7a48370571072c74c09c6347 (HEAD -> master, origin/master, origin/HEAD) Author: Andreas K. Hüttel <dilfridge@gentoo.org> Date: Thu Jan 5 10:40:54 2017 +0100 Revert "dev-lang/perl: Restore MANIFEST sort order, bug 589302" This commit / patch is not needed since we already have a fix for the bug. See https://github.com/gentoo-perl/perl-patchset/commit/23179a630d04c3d40e7c09bccbf2f38f3ad72b93 This reverts commit 1ddfb9cc7eb204864bcf113b74ca4c5c9780c84a. dev-lang/perl/files/perl-patchlevel-manifest.patch | 10 ---------- dev-lang/perl/perl-5.24.1_rc4.ebuild | 6 +++--- 2 files changed, 3 insertions(+), 13 deletions(-) |