Bug 586318

Summary:	media-video/mpv: invalid use of \|\| ( lua:= ... ) dep
Product:	Gentoo Linux	Reporter:	Michał Górny <mgorny>
Component:	Current packages	Assignee:	Coacher <itumaykin+gentoo>
Status:	RESOLVED FIXED
Severity:	normal	CC:	maksbotan, media-video, proxy-maint, yngwin
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	586238

Description Michał Górny archtester

2016-06-18 19:18:20 UTC

!luajit? ( || ( =dev-lang/lua-5.1*:= =dev-lang/lua-5.2*:= ) )

Use of := inside || is forbidden and broken.

Since you are entirely happy with both lua versions in-tree, why don't you depend on dev-lang/lua:=?

Comment 1 Michał Górny archtester

2016-06-18 19:19:04 UTC

Also, the metadata.xml is quite unclear on maintainers. yngwin is listed as primary, yet descriptions say to assign to proxied maint. If the latter is desired, please put him first.

Comment 2 Coacher 2016-06-21 11:16:46 UTC

(In reply to Michał Górny from comment #1)
> Also, the metadata.xml is quite unclear on maintainers. yngwin is listed as
> primary, yet descriptions say to assign to proxied maint. If the latter is
> desired, please put him first.

yngwin is on devaway.

maksbotan was a proxy developer for the previous proxy maintainer and is a member of proxy-maint team. I've asked him if he still prefers to be listed explicitly.

Reality is the most of maintaining is done by me now.

I'll update metadata accordingly later today.

Comment 3 Coacher 2016-06-21 16:03:49 UTC

(In reply to Michał Górny from comment #0)
> !luajit? ( || ( =dev-lang/lua-5.1*:= =dev-lang/lua-5.2*:= ) )
> 
> Since you are entirely happy with both lua versions in-tree, why don't you
> depend on dev-lang/lua:=?
This dependency specification was introduced before I started maintaining mpv.
I'll fix it later today as well. Thanks.

Comment 4 Coacher 2016-06-21 19:28:35 UTC

(In reply to Coacher from comment #2)
> (In reply to Michał Górny from comment #1)
> > Also, the metadata.xml is quite unclear on maintainers. yngwin is listed as
> > primary, yet descriptions say to assign to proxied maint. If the latter is
> > desired, please put him first.
> 
> yngwin is on devaway.
> 
> maksbotan was a proxy developer for the previous proxy maintainer and is a
> member of proxy-maint team. I've asked him if he still prefers to be listed
> explicitly.
> 
> Reality is the most of maintaining is done by me now.
> 
> I'll update metadata accordingly later today.
https://github.com/gentoo/gentoo/pull/1709

Comment 5 Coacher 2016-06-21 20:00:39 UTC

(In reply to Coacher from comment #3)
> (In reply to Michał Górny from comment #0)
> > !luajit? ( || ( =dev-lang/lua-5.1*:= =dev-lang/lua-5.2*:= ) )
> > 
> > Since you are entirely happy with both lua versions in-tree, why don't you
> > depend on dev-lang/lua:=?
> This dependency specification was introduced before I started maintaining
> mpv.
> I'll fix it later today as well. Thanks.
https://github.com/gentoo/gentoo/pull/1710

Comment 6 Coacher 2016-06-21 20:21:35 UTC

commit 687a2df580d068b5a197c0535df51884cd9f8305
Author: Ilya Tumaykin <itumaykin@gmail.com>
Date:   Tue Jun 21 22:34:23 2016 +0300

    media-video/mpv: fix dev-lang/lua dependency wrt bug 586318

    mpv is known to be broken with Lua 5.3.
    Even though Lua 5.3 isn't in tree yet, I'd prefer to have the fact that
    it breaks mpv to be expressed as a dependency.

    Gentoo-Bug: 586318

    Package-Manager: portage-2.3.0_rc1

Comment 7 Göktürk Yüksek archtester

2016-06-26 12:49:55 UTC

(In reply to Coacher from comment #4)
> (In reply to Coacher from comment #2)
> > (In reply to Michał Górny from comment #1)
> > > Also, the metadata.xml is quite unclear on maintainers. yngwin is listed as
> > > primary, yet descriptions say to assign to proxied maint. If the latter is
> > > desired, please put him first.
> > 
> > yngwin is on devaway.
> > 
> > maksbotan was a proxy developer for the previous proxy maintainer and is a
> > member of proxy-maint team. I've asked him if he still prefers to be listed
> > explicitly.
> > 
> > Reality is the most of maintaining is done by me now.
> > 
> > I'll update metadata accordingly later today.
> https://github.com/gentoo/gentoo/pull/1709

Author:     Ilya Tumaykin <itumaykin@gmail.com>
AuthorDate: Tue Jun 21 22:24:32 2016 +0300
Commit:     Göktürk Yüksek <gokturk@gentoo.org>
CommitDate: Sun Jun 26 08:44:20 2016 -0400

    media-video/mpv: reorder maintainers in metadata, remove yngwin
    
    Remove yngwin from the metadata per his request and list Coacher as
    the first maintainer.
    
    See also https://bugs.gentoo.org/show_bug.cgi?id=586318#c1
    
    Closes: https://github.com/gentoo/gentoo/pull/1709
    Package-Manager: portage-2.3.0_rc1
    RepoMan-Options: --force