Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 582802

Summary: distcc path should respect EPREFIX
Product: Portage Development Reporter: Benda Xu <heroxbd>
Component: Core - External InteractionAssignee: Portage team <dev-portage>
Status: RESOLVED FIXED    
Severity: normal CC: prefix
Priority: Normal Keywords: InVCS, PATCH
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 315803    
Attachments: portage-2.2.28-distcc-eprefix.patch
portage-2.3.0-scanelf-path.patch

Description Benda Xu gentoo-dev 2016-05-12 04:55:51 UTC
This patch prepends EPREFIX to the distcc path.

Reproducible: Always
Comment 1 Benda Xu gentoo-dev 2016-05-12 04:56:48 UTC
Created attachment 434030 [details, diff]
portage-2.2.28-distcc-eprefix.patch
Comment 2 Benda Xu gentoo-dev 2016-05-20 00:44:37 UTC
Ping portage team.
Comment 3 Benda Xu gentoo-dev 2016-06-02 09:42:27 UTC
Ping portage team.
Comment 4 Zac Medico gentoo-dev 2016-06-06 07:18:06 UTC
(In reply to Benda Xu from comment #1)
> Created attachment 434030 [details, diff] [details, diff]
> portage-2.2.28-distcc-eprefix.patch

Actually, mysettings["EPREFIX"] is wrong when dealing with "cross-prefix" situations. So, portage.const.EPREFIX is the right thing to use here (like bug 583754).
Comment 5 Benda Xu gentoo-dev 2016-06-06 10:37:12 UTC
(In reply to Zac Medico from comment #4)
> (In reply to Benda Xu from comment #1)
> > Created attachment 434030 [details, diff] [details, diff] [details, diff]
> > portage-2.2.28-distcc-eprefix.patch
> 
> Actually, mysettings["EPREFIX"] is wrong when dealing with "cross-prefix"
> situations. So, portage.const.EPREFIX is the right thing to use here (like
> bug 583754).

Nice catch Zac! I just realized it a minute ago.
Comment 6 Benda Xu gentoo-dev 2016-06-06 13:24:13 UTC
Created attachment 436632 [details, diff]
portage-2.3.0-scanelf-path.patch

Updated, thanks!
Comment 7 Zac Medico gentoo-dev 2016-06-06 16:05:38 UTC
Thanks, this is in the master branch:

https://gitweb.gentoo.org/proj/portage.git/commit/?id=67239a3f48989794ffe484206bc6afc40156d9db
Comment 8 Benda Xu gentoo-dev 2016-06-30 13:47:34 UTC
Included in 2.3.0 release.