Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 582766

Summary: media-sound/clementine: multiple missing dependencies required for detecting MP3 players/USB devices
Product: Gentoo Linux Reporter: Valeriy Malov <jazzvoid>
Component: Current packagesAssignee: Fat-Zer <fatzer2>
Status: RESOLVED FIXED    
Severity: normal CC: polynomial-c, proxy-maint, sound
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on: 595600    
Bug Blocks: 588908    

Description Valeriy Malov 2016-05-11 16:58:07 UTC
Clementine currently has two backends for detecting MP3 players that are connected as removable USB devices, GIO (enabled by default in the ebuild) and devicekit (enabled by udisks use flag)

GIO backend using GVolumeMonitor without gvfs[udev udisks] installed just doesn't work for me as expected, it just returns list of local mounts. Installing gvfs fixed the problem for me.

Devicekit backend seems to have a dependency problem, ebuild states that it requires udisks:2 but Clementine explicitly depends on dbus path provided by udisks:0 (see https://github.com/clementine-player/Clementine/blob/master/src/devices/devicekitlister.cpp#L47), and without udisks:0 this backend doesn't work at all

Steps to reproduce:
* Unmerge gvfs or emerge it without [udisks]
* Unmerge udisks:0
* Plug a usb flash drive, run Clementine, click on "devices", see nothing useful

Possible solutions:
* clementine[udisks] should pull in udisks:0
* Depend on gvfs[udisks] by default or turn HAVE_GIO into a use-flag
Comment 1 Fat-Zer 2016-09-20 17:28:06 UTC
Good day, the dependence upon udisks:0 is already fixed some time ago in media-sound/clementine-1.2.3-r1 and 1.3.1-r1. The fix wasn't committed to stable version (1.2.3) due to gentoo policies. Also note that git master and the live ebuild provides optional support for both udisks:{0,2}.

I don't see a lot of sense in introducing a flag for gvfs/gio: it won't eradicate a dependency due to gio is part of glib; gvfs doesn't have any other backends for detecting external drives, so IMHO there is no use case and no benifits in accessing them through the chain of gio-gvfs-udisks rather than the direct connection to udisks.

All in all, it's ok and pretty straightforward to adhere the position «you won't have support for your mp3 player unless you build clementine with udisks support» here.

Closing the bug in a couple of weeks if there are no objections.
Comment 2 Kristian Fiskerstrand (RETIRED) gentoo-dev 2016-09-20 17:36:43 UTC
(In reply to Fat-Zer from comment #1)
> Good day, the dependence upon udisks:0 is already fixed some time ago in
> media-sound/clementine-1.2.3-r1 and 1.3.1-r1. The fix wasn't committed to
> stable version (1.2.3) due to gentoo policies. Also note that git master and


That doesn't preclude bringing the fixed version into stable through stabilization request after sufficient time in testing. Currently InVCS keyword is used to mark fixed in testing (~arch)