Bug 581912 – [gnome-overlay] gnome-extra/evolution-data-server specifies webkit-gtk as rdepend

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Amit Prakash Ambasta 2016-05-03 05:58:51 UTC]

While webkit-gtk is required for --enable-google/--enable-google-auth, eds 3.20 should not need webkit-gtk otherwise.

Built and tested locally without webkit as a rdepend.



Reproducible: Always

[Comment 1 Amit Prakash Ambasta 2016-05-03 06:00:15 UTC]

Created attachment 433010 [details]
Fixed & Bumped ebuild

[Comment 2 Pacho Ramos 2016-06-22 19:45:59 UTC]

As explained at:
https://bugzilla.gnome.org/show_bug.cgi?id=749974#c30

I would vote for moving it beside a "webkit" USE flag instead to try to avoid the pulling of old webkit-gtk:3 slot in favor of using GOA (that uses webkit-gtk:4) for people enabling "google" support for gmail accounts

[Comment 3 Gilles Dartiguelongue (RETIRED) 2016-06-24 16:20:14 UTC]

This flag is about the "create google accounts when g-o-a isn't there" feature. Imho this needs to stay named USE=google. Also this USE flag should probably need a REQUIRED_USE="google? ( gtk )"

[Comment 4 Pacho Ramos 2016-06-24 18:46:05 UTC]

Anyway, I would avoid to pull the additional webkit-gtk slot for people running gnome-online-accounts :|

The problem here is that we should try to avoid people from keep pulling all webkit-gtk slots by default. And, as most people will have gnome-online-accounts and google USE flags enabled (as people will want to support gmail stuff), we are in trouble :S

[Comment 5 Pacho Ramos 2016-06-24 18:49:00 UTC]

Other option would be that google + gnome-online-accounts ends relying on gnome-online-accounts... and for people with google and -gnome-online-accounts, rely on the old webkit-gtk slot :/

[Comment 6 Ole Reifschneider (RETIRED) 2016-06-25 11:51:45 UTC]

I just merged a pull request that removed it. Now it is only required when the google use flag is enabled.

I think that's fine for now and the bug can be closed. What do you guys think?

[Comment 7 Pacho Ramos 2016-06-25 12:03:27 UTC]

That it doesn't handle my concerns at all and, by default, this will cause people to need to install one webkit-gtk slot (that is also vulnerable) even if they can also use "google" as they do at present time (relying on gnome-online-accounts)

[Comment 8 Pacho Ramos 2016-06-30 09:38:45 UTC]

Maybe one option would be to, even relying on "google" USE flag for pulling webkit-gtk:3, don't enable it by default (I mean, don't set +google as currently) and show an elog message when gnome-online-accounts and google USE flags are both enabling "reminding people" that they can disable "google" if they want to skip the building of a second (and vulnerable) webkit-gtk slot and rely in GOA (as we all were relying on until now)

[Comment 9 Gilles Dartiguelongue (RETIRED) 2016-06-30 22:02:23 UTC]

Ok for dropping the default +, it makes sense to not pull things by default that are already covered by g-o-a which is default activated.

As for "reminding" people, using elog is probably not going to be effective, this is not worth a news item either. I think we can just rely on user common sense that "omg why do I need 3 webkit-gtk installed" and have a proper local description for the USE flag. Even with powerful boxes I own, I pay attention to why webkit gets pulled in.

If you want to be extreme, you can always make the USE flags block each other or even mask it.

[Comment 10 Pacho Ramos 2016-07-02 13:06:35 UTC]

For now I will opt for not enabling it by default and relying on metadata.xml for informing the people

Thanks guys!