Summary: | nethack-3.3.1 (New Package) | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Bob Phan <bob> |
Component: | New packages | Assignee: | chouser (RETIRED) <chouser> |
Status: | RESOLVED INVALID | ||
Severity: | enhancement | CC: | bob, hanno |
Priority: | High | ||
Version: | 1.0 RC6 r14 | ||
Hardware: | x86 | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | nethack-3.3.1 |
Description
Bob Phan
2002-02-07 01:40:10 UTC
Created attachment 135 [details]
nethack-3.3.1
This looks like really painful app to package -- thanks for tackling it. I created a ChangeLog and moved your author credit line to there. The verbose comments are very good, especially for an unusual package like this. If parallel make (emake) doesn't work for a package, it is helpful to have a comment, so that there is not doubt that it's not just a typo or a copy-and-paste error. I see you used both patches and sed scripts to fix things and set compile options. I personally do all I can to avoid diff-based patches, but your solutions seem entirely acceptable. I did consolidate a few of your sed scripts. There are several 'do' commands in /usr/lib/portage/bin that can be useful, especially in the 'install' section. I replaced a few of the install lines with a 'dodoc' call. I asked around about putting this in /usr/games, and so now we have a new gentoo policy to avoid that. ;-) I've tried to move everything, but I'm not sure it's working yet. Source patching should be done in unpack instead of compile. As a general rule, the compile step should be repeatable, and patches (and usually sed scripts, too) are NOT repeatable. I'm not going to mess with it at this point, since that's a minor gripe, but keep it in mind for the future. I had to set CFLAGS specifically on the make command-line in order for the settings in /etc/make.conf to take effect. Unfortunately, this also overrides settings applied by patch into the Makefile that we actually need, so I had to duplicate these in the ebuild. Well, I'm still not comfortable checking this in quite yet. I think it's close, but it needs a bit more testing and some polish. If you want to see what I've done so far, critisize my changes, or make changes of your own, just send me email. ;-) --Chouser nethack 3.4.0 is in portage, so this bug seems to be obsolete. can be closed. |