Summary: | media-video/mplayer-1.2.1: add vcd and yuv4mpeg USE flags | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | nobody |
Component: | Current packages | Assignee: | Gentoo Media-video project <media-video> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | Keywords: | PATCH |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | mplayer-1.2.1-vcd-yuv4mpeg-flags.diff |
what is the gain in disabling these ? Binary file is just ~10KB smaller, but I think user should be able to disable anything he wants. Maybe it's wrong opinion. (In reply to nobody from comment #2) > but I think user should be able to > disable anything he wants. I tend to agree with that, but I also think having too many useflags does not help (mplayer has quite a bunch of them already and could probably gain a few dozens more): it becomes very hard to distinguish between what provides a real gain and what is almost irrelevant. anyway, I have nothing against it, but please submit a more complete patch, ideally a github pull request: - metadata.xml change with use descriptions is missing - ebuild updates for mplayer are first made to -9999 and then backported to releases; you can do all the changes in one commit, but yours is missing -9999 update PR merged, thanks! |
Created attachment 425574 [details, diff] mplayer-1.2.1-vcd-yuv4mpeg-flags.diff This flags are needed to disable some unnecessary features. Check the patch. Maybe yuv4mpeg flag should be renamed, etc.