Bug 57224 - agriffis borked libtool-1.5.2-r5 for mips/mips64/ppc64/uclibc
Bug#: 57224 Product:  Gentoo Linux Version: unspecified Platform: PPC64
OS/Version: All Status: CLOSED Severity: normal Priority: P2
Resolution: FIXED Assigned To: ppc64@gentoo.org Reported By: brad@mainstreetsoftworks.com
Component: Applications
URL: 
Summary: agriffis borked libtool-1.5.2-r5 for mips/mips64/ppc64/uclibc
Keywords:  
Status Whiteboard: 
Opened: 2004-07-15 14:10 0000
Description:   Opened: 2004-07-15 14:10 0000
He tried to clean some stuff up ... here is a patch
that refixes the arches messed up, and finishes cleaning up
some stuff.

-Brad

------- Comment #1 From Brad House 2004-07-15 14:11:36 0000 -------
Created an attachment (id=35505) [details]
patch for libtool 1.5.2-r5 ebuild

------- Comment #2 From Tom Gall 2004-07-15 14:21:27 0000 -------
thanks brad, you've saved the day once again!

------- Comment #3 From Tom Gall 2004-07-15 14:22:56 0000 -------
stick a fork in it

------- Comment #4 From Aron Griffis (RETIRED) 2004-07-15 21:03:25 0000 -------
:-(  Sorry about the breakage.

In truth, though, the invocations of gnuconfig_update in the libtool ebuilds were really screwed up.  It appears that somebody thought that gnuconfig_update depends on current working directory.  That's the only explanation I can think of for this kind of stuff in the ebuild:

   cd ${OLD_S}
   use mips && gnuconfig_update

   cd ${S}
   use mips && gnuconfig_update

What they didn't realize was that OLD_S was being fixed by an earlier invocation of gnuconfig_update which overrode S in src_unpack.  The later calls to gnuconfig_update were superfluous already because they were all happening in ${S}!

Recently I gave gnuconfig_update the ability to accept a starting directory as the first parameter.  So in this case I have changed the libtool ebuilds to call

   gnuconfig_update ${WORKDIR}

at the end of src_unpack (after all patches are applied so that the patches aren't broken).  This updates the gnuconfig stuff for all the source directories under ${WORKDIR}.  I've tested all the versions to make sure it's right.

So... my apologies for borking it!  :-(  On the other hand... it's a lot better now :-)  (and thanks Brad and Tom for catching the problem and putting in an initial fix)

------- Comment #5 From Aron Griffis (RETIRED) 2004-07-15 21:04:18 0000 -------
*** Bug 57190 has been marked as a duplicate of this bug. ***