Bug 570666

Summary:	dev-util/buildbot-0.8.12 - Support for multiple buildmaster instances
Product:	Gentoo Linux	Reporter:	Michael Seifert <m.seifert>
Component:	[OLD] Development	Assignee:	Markos Chandras (RETIRED) <hwoarang>
Status:	RESOLVED FIXED
Severity:	enhancement	CC:	m.seifert, monsieurp
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	buildmaster_at.service buildmaster_at.service.conf buildmaster.initd.patch buildbot-0.8.12.patch

Description Michael Seifert 2016-01-02 21:59:07 UTC

The installed services of dev-util/buildbot-0.8.12 do not allow for starting multiple instances of buildmaster.

The attached patch set provides support for starting and stopping multiple buildmaster instances on both OpenRC and systemd systems.

I also adjusted the service names so they are the same for both init systems. Previously, the ebuild installed a "buildmaster" service in /etc/init.d/ and a "buildbot.service" in the systemd unit dir. I chose to change the systemd service name to "buildmaster", since "buildbot" is the legacy name according to the buildbot docs [1].

[1] http://docs.buildbot.net/0.8.12/manual/installation.html

Reproducible: Always

Comment 1 Michael Seifert 2016-01-02 22:00:28 UTC

Created attachment 421692 [details]
buildmaster_at.service

Systemd service file to start a buildmaster instance.

Comment 2 Michael Seifert 2016-01-02 22:01:34 UTC

Created attachment 421694 [details]
buildmaster_at.service.conf

Systemd service configuration file.
The configuration file allows to change the base directory where the buildmaster instances should reside.

Comment 3 Michael Seifert 2016-01-02 22:07:33 UTC

Created attachment 421696 [details, diff]
buildmaster.initd.patch

Adds support for multiple buildmaster instances to the init script.

Comment 4 Michael Seifert 2016-01-02 22:08:37 UTC

Created attachment 421698 [details, diff]
buildbot-0.8.12.patch

Installs all service files.

Comment 5 Patrice Clement gentoo-dev

2016-03-21 22:07:06 UTC

ping Michael. Can you take a look at the PR please? Thanks! :)

Comment 6 Michael Seifert 2016-03-22 19:14:12 UTC

Done. Thanks for the reminder!

Comment 7 Patrice Clement gentoo-dev

2016-03-30 12:17:47 UTC

commit 4720572e0dcdf0638d64a59b13816bd73449fb73 (HEAD -> master)
Author:     Michael Seifert <mseifert@error-reports.org>
AuthorDate: Tue Mar 22 20:03:02 2016 +0100
Commit:     Patrice Clement <monsieurp@gentoo.org>
CommitDate: Wed Mar 30 12:03:42 2016 +0000

dev-util/buildbot: Added migration guide and updated setup instructions.

buildbot-0.8.12-r2 prints ewarn messages when migrating from a previous
version. The messages describe the necessary steps to migrate properly. In
addition to this, the user is notified of the support for emerge --config and
DOC_CONTENT was updated to point to the possibility of using it.

This string of 5 commits merges gentoo/gentoo#1027 and solves bug #570666.

Gentoo-Bug: https://bugs.gentoo.org/570666
Acked-By: Markos Chandras hwoarang@gentoo.org>
Closes: https://github.com/gentoo/gentoo/pull/1027

Signed-off-by: Patrice Clement <monsieurp@gentoo.org>

dev-util/buildbot/buildbot-0.8.12-r2.ebuild | 49 +++++++++++++++++++++++++++++++------------------
1 file changed, 31 insertions(+), 18 deletions(-)