Bug 567570

Summary:	=x11-plugins/pidgin-sipe-1.20.1 not seen by pidgin
Product:	Gentoo Linux	Reporter:	Octavian <octavsly>
Component:	Current packages	Assignee:	Manuel Rüger (RETIRED) <mrueg>
Status:	RESOLVED FIXED
Severity:	normal	CC:	klondike, net-im, thev00d00
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	Patch to fix the SIPE checks for SRTP Upstream patch

Description Octavian 2015-12-05 08:44:30 UTC

The Office Communicator protocol does not appear anymore in pidging with =x11-plugins/pidgin-sipe-1.20.1 version. 

However, version=x11-plugins/pidgin-sipe-1.20.0 is OK.

Comment 1 Manuel Rüger (RETIRED) gentoo-dev

2015-12-06 22:28:10 UTC

There haven't been many changes between .0 and .1, probably I missed a configure change?
see: http://repo.or.cz/w/siplcs.git

Comment 2 Ian Whyman (thev00d00) (RETIRED) gentoo-dev

2015-12-10 08:56:42 UTC

@Octavian
Do you have USE="voice"?

Can you attach a pidgin debug log?

Comment 3 Octavian 2015-12-10 09:12:31 UTC

Yes, I have USE="voice"

I am using it in a production environment and I have little spare time. Wrote the ticket so others have at least a solution. If it's not a trivial fix I would wait for the next version.

Comment 4 Francisco Blas Izquierdo Riera (RETIRED) gentoo-dev

2015-12-10 10:33:04 UTC

The relevant part of the debug output is these two lines:

(11:30:25) plugins: probing /usr/lib64/purple-2/libsipe.so
(11:30:25) plugins: /usr/lib64/purple-2/libsipe.so is not loadable: undefined symbol: purple_media_set_decryption_parameters


Seems they aren't checking for some symbols properly at configure time.

Comment 5 Francisco Blas Izquierdo Riera (RETIRED) gentoo-dev

2015-12-10 10:59:24 UTC

Created attachment 418924 [details, diff]
Patch to fix the SIPE checks for SRTP

This patch makes the plugin work as expected again.

Comment 6 Octavian 2015-12-10 11:14:15 UTC

I can confirm that this patch applied to 1.20.1 solves the issue.
Probably it needs to be pushed in portage.

Comment 7 Ian Whyman (thev00d00) (RETIRED) gentoo-dev

2015-12-10 11:33:19 UTC

I wont be able commit this until tomorrow at the earliest, but LGTM. I will inform upstream also.

mrueg / klondike: feel free commit this.

Comment 8 Francisco Blas Izquierdo Riera (RETIRED) gentoo-dev

2015-12-11 19:31:37 UTC

Created attachment 418994 [details, diff]
Upstream patch

This one backports the change from commit http://repo.or.cz/siplcs.git/commit/eb11d75236bc88fbf61b1b47159c3dd6140b74c5 by Stefan Becker.

I tested it and it works too. I can't commit to the gentoo repo so don't ask me to fix more here :(

Comment 9 Ian Whyman (thev00d00) (RETIRED) gentoo-dev

2015-12-18 11:49:58 UTC

Finally in the tree[1]

Thanks for reporting/patches.

1. https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=35c829b8b9a3d6a3f2a67568f65a320f7d6bc1f5