Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 562256

Summary: media-video/libav add libressl support
Product: Gentoo Linux Reporter: Julian Ospald <hasufell>
Component: [OLD] LibraryAssignee: Gentoo Media-video project <media-video>
Status: RESOLVED FIXED    
Severity: normal    
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
URL: https://github.com/gentoo/gentoo/pull/152
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 561854    
Attachments: 0001-media-video-libav-add-libressl-support.patch

Description Julian Ospald 2015-10-04 19:54:33 UTC
Created attachment 413744 [details, diff]
0001-media-video-libav-add-libressl-support.patch

This also removes 'openssl' USE flag, because libav is the only ebuild so far which uses 'openssl' to choose the provider for ssl. All others use 'gnutls', some use 'openssl' for _features_ (not to choose the provider). That will cause a mess when people try to do USE="-openssl libressl" and the ebuild works fine without this USE flag anyway, as can be seen in the attached patch.
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2015-10-04 20:06:27 UTC
Nah, I don't think that's exactly it. Wouldn't USE=libressl supposed to be enabled globally to get rid of openssl? In this case, USE=gnutls on libav would collide with it unnecessarily.
Comment 2 Julian Ospald 2015-10-04 20:12:53 UTC
(In reply to Michał Górny from comment #1)
> Nah, I don't think that's exactly it. Wouldn't USE=libressl supposed to be
> enabled globally to get rid of openssl? In this case, USE=gnutls on libav
> would collide with it unnecessarily.

you cannot enable gnutls and libressl at the same time (only for a few ebuilds), so you either randomly choose something or have REQUIRED_USE force consistent ssl provider choice
Comment 3 Julian Ospald 2015-10-05 08:25:57 UTC
another way without changing USE flags much would be

 	ssl? (
-		openssl? ( >=dev-libs/openssl-1.0.1h-r2[${MULTILIB_USEDEP}] )
-		!openssl? ( >=net-libs/gnutls-2.12.23-r6[${MULTILIB_USEDEP}] )
+		openssl? (
+			!libressl? ( >=dev-libs/openssl-1.0.1h-r2:0[${MULTILIB_USEDEP}] )
+			libressl? ( dev-libs/libressl[${MULTILIB_USEDEP}] )
+		)
+		!openssl? ( >=net-libs/gnutls-2.12.23-r6[${MULTILIB_USEDEP}] )
 	)
Comment 4 Julian Ospald 2015-10-17 13:33:03 UTC
(In reply to Julian Ospald (hasufell) from comment #3)
> another way without changing USE flags much would be
> 
>  	ssl? (
> -		openssl? ( >=dev-libs/openssl-1.0.1h-r2[${MULTILIB_USEDEP}] )
> -		!openssl? ( >=net-libs/gnutls-2.12.23-r6[${MULTILIB_USEDEP}] )
> +		openssl? (
> +			!libressl? ( >=dev-libs/openssl-1.0.1h-r2:0[${MULTILIB_USEDEP}] )
> +			libressl? ( dev-libs/libressl[${MULTILIB_USEDEP}] )
> +		)
> +		!openssl? ( >=net-libs/gnutls-2.12.23-r6[${MULTILIB_USEDEP}] )
>  	)

applied this form

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=97619fe996cd0638683e3ad05cfe707b088cfb29