Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 551156

Summary: intel-sdp.eclass: incorrect use of nonfatal
Product: Gentoo Linux Reporter: Michał Górny <mgorny>
Component: EclassesAssignee: Justin Lecher (RETIRED) <jlec>
Status: RESOLVED FIXED    
Severity: normal CC: jlec, sci
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 551152    

Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2015-06-04 08:56:49 UTC
if [[ -d "${INTEL_SDP_DIR}"/man ]]; then
        nonfatal doman "${INTEL_SDP_DIR}"/man/en_US/man1/*
        nonfatal doman "${INTEL_SDP_DIR}"/man/man1/*

This is incorrect. nonfatal is meant to be used to provide custom error handling, not ignore errors. You want to check for files matching the pattern properly (path_exists from eutils? package name/version matching?).
Comment 1 Justin Lecher (RETIRED) gentoo-dev 2015-06-04 10:22:58 UTC
+  04 Jun 2015; Justin Lecher <jlec@gentoo.org> intel-sdp.eclass:
+  Fix homepage url for license registration, #538284; do a precheck instead fo
+  using nonfatal, #551156
+