Bug 543066

Summary:	net-libs/webkit-gtk-2.6 build issue with GMutexLock, added in glib-2.44
Product:	Gentoo Linux	Reporter:	Olaf Leidinger <oleid>
Component:	[OLD] GNOME	Assignee:	Gentoo Linux Gnome Desktop Team <gnome>
Status:	RESOLVED FIXED
Severity:	normal	CC:	canarauc, cynede
Priority:	Normal	Keywords:	InVCS
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	https://bugs.webkit.org/show_bug.cgi?id=141381
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	change name space usage in webkit code Patch for ver. 2.4.8 GCC patch, previous one does not work

Description Olaf Leidinger 2015-03-12 14:52:11 UTC

A build error occurs when using a very recent glib version (I think > 2.42; I'm using 2.43.91 to test GNOME 3.16), c.f. the URL. This error will hit people as soon as glib-2.44 lands in the tree.

When using the attached patch, Webkit-GTK builds fine. It's a safe patch, as it only changes the name space usage in the webkit code.

Reproducible: Always

Steps to Reproduce:
1.install >= glib 2.43
2.emerge webkit-gtk

Comment 1 Olaf Leidinger 2015-03-12 14:54:08 UTC

Created attachment 398740 [details, diff]
change name space usage in webkit code

It's basically the patch from the upstream bug report minus the changes to files, which don't exist.

Comment 2 Pacho Ramos gentoo-dev

2015-03-13 06:47:55 UTC

Maybe you should wait a bit more as I guess webkit-gtk-2.8 will include that fix as both, webkit-gtk and glib versions, are meant to be in sync for the 3.16 cycle ;)

Comment 3 Can Selcuk 2015-04-03 07:53:16 UTC

Hi I have a simmilar issue with webkit-gtk-2.4.8. I tried the posted patch but it does not apply on the 2.4.8 version.

Comment 4 Cănărău Constantin 2015-04-09 07:19:58 UTC

Created attachment 400884 [details, diff]
Patch for ver. 2.4.8

Tested and compiled succesfully with clang-3.6.0

Comment 5 Cănărău Constantin 2015-04-09 08:08:43 UTC

Created attachment 400888 [details, diff]
GCC patch, previous one does not work

GCC patch, previous one does not work

Comment 6 Joakim Tjernlund 2015-04-28 19:54:59 UTC

webkit-gtk-2.6.6 is out and has:
 - Fix the build with recent versions of GLib that have GMutexLocker.

Comment 7 Gilles Dartiguelongue (RETIRED) gentoo-dev

2015-05-01 13:28:27 UTC

We should include upstream patch or bump to fixed versions.

Comment 8 Gilles Dartiguelongue (RETIRED) gentoo-dev

2015-05-02 16:19:15 UTC

+*webkit-gtk-2.6.6 (02 May 2015)
+
+  02 May 2015; Gilles Dartiguelongue <eva@gentoo.org> +webkit-gtk-2.6.6.ebuild:
+  Version bump. Fixes build with newer glib, bug #543066. Add support for
+  building with ruby 2.2, bug #534010. Add missing webgl? ( opengl )
+  constraint, bug #533704. Fix build with older glibc releases, bug #533976.
+
Thanks for reporting.

Comment 9 Cynede (RETIRED) gentoo-dev

2015-05-23 07:43:26 UTC

I've got this issue with webkit-gtk 2.4.8, it's only one for slot 2

there should be limitation for glib < 2.44 or alike or patch...

Comment 10 Cynede (RETIRED) gentoo-dev

2015-05-23 07:44:13 UTC

* slot 2 and slot 3

Comment 11 Cynede (RETIRED) gentoo-dev

2015-05-23 07:48:57 UTC

also fails if I'm trying to build with clang 3.6.0