Summary: | dnstracer-1.7-r1.ebuild (update) | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Jonathan Stewart <reaper> |
Component: | New packages | Assignee: | Gentoo Netmon project <netmon> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | CC: | reaper |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
dnstracer-1.7-r1.ebuild (update)
dnstracer-1.7-r1.ebuild |
Description
Jonathan Stewart
2004-06-17 03:15:58 UTC
Created attachment 33418 [details]
dnstracer-1.7-r1.ebuild (update)
Simple if then added to check for ipv6 USE flag.
A few comments: 1. S=${WORKDIR}/${P} is redundant 2. you specified a src_compile without a make. the ebuild will do a make (because of the make install in src_install), but it is not proper. 3. if you need to disable or enable a configure switch according to a useflag use the following format: econf `use_enable ipv6` Here is a revised src_compile: src_compile () { econf `use_enable ipv6` || die emake || die } Oh, and also don't forget to ~mask all the archs: x86 -> ~x86, etc. Created attachment 33754 [details]
dnstracer-1.7-r1.ebuild
Thanks for the improvements, Eldad. Like i said, this is my first attempt, and i wasn't sure of the proper way to make an ebuild. Your looks much nicer. Can this improved ebuild be accepted then? Yep. Also, you might want to check out these docs: http://www.gentoo.org/doc/en/gentoo-howto.xml http://www.gentoo.org/doc/en/ebuild-mistakes.xml and maybe http://www.gentoo.org/doc/en/ebuild-submit.xml too. and then there's "man 5 ebuild" to consult... in portage, thanks! |