Bug 54016 - [ebuild update] app-vim/cream-0.30
Bug#: 54016 Product:  Gentoo Linux Version: unspecified Platform: All
OS/Version: All Status: RESOLVED Severity: enhancement Priority: P4
Resolution: FIXED Assigned To: vim@gentoo.org Reported By: tom.gl@free.fr
Component: Ebuilds
URL:  http://cream.sourceforge.net/changelog.html
Summary: [ebuild update] app-vim/cream-0.30
Keywords:  EBUILD
Status Whiteboard: 
Opened: 2004-06-15 12:56 0000
Description:   Opened: 2004-06-15 12:56 0000 
Hi Ciaranm,

Cream 0.30 has been released. It's a minor bugfixes release. The good thing is that we don't have anything to patch anymore (but the installation path).

I will submit the ebuild update as a patch against the 0.29-r1 one.

Thanks,
Thomas.

------- Comment #1 From TGL 2004-06-15 12:57:27 0000 ------- 
Created an attachment (id=33336) [details]
cream.ebuild--0.29-r1_to_0.30.patch

------- Comment #2 From Ciaran McCreesh 2004-06-15 15:39:01 0000 ------- 
Thanks very much for the ebuild.

Hm. Just noticed this when exiting:

(gvim:1541): GLib-GObject-CRITICAL **: file gobject.c: line 1579 (g_object_unref): assertion `G_IS_OBJECT (object)' failed
Vim: Caught deadly signal SEGV
Vim: Finished.

Happens on earlier versions of both gvim and cream as well. You'll only see it if you run cream from within a term.

I'm going to commit the 0.30 ebuild anyway once my cvs upd is done, since all versions of cream in portage are affected by this. However, we probably want to talk to upstream to see whether this is something we're breaking or whether it's a universal bug.

BTW, it's generally considered ok to leave in ~arch for existing archs when doing relatively minor version bumps.

Leaving the bug open for now until we figure out the SEGV.

------- Comment #3 From TGL 2004-06-15 16:58:02 0000 ------- 
The bug you've seen already happened to me, and is not really specific to Cream
but can happen as soon as you create a toolbar button with an icon from a
bitmap file (ie. not one of the usual icons, which are included in the binary
and are loaded by a different piece of code). I've reported it to vim-dev some
time ago:
http://marc.theaimsgroup.com/?l=vim-dev&m=108317705302808

The problem is that I don't know for sure whether the code I've replaced in
this patch was correct or not (meaning whether it was a gtk bug that i've
workaround or a gvim bug that i've fixed). And now I can't reproduce it
anymore, which doesn't help... (this may mean that it was a gtk bug fixed in
one of the recent updates, but who knows... And i've not found anything
relevant in changelogs.) 
What versions of glib/gtk+ are you using?

------- Comment #4 From TGL 2004-06-22 08:16:41 0000 ------- 
Ok, I've redone a few tests and can now confirm that the bug was in gtk+
=<2.4.1, and not in gvim. It doesn't occur anymore with gtk+-2.4.3.  

The relevent gtk change that fixed that, and which has been included in
gtk+-2.4.2, is here:
http://bugzilla.gnome.org/attachment.cgi?id=27410&action=view

And the patch i've submitted to vim-dev was actually not a fix but only a
workaround for this GtkIconSource bug.

I don't know, maybe that implies a dependencies changes in gvim ebuild?
Something like changing ">=x11-libs/gtk+-2.2" to "|| ( =x11-libs/gtk+-2.2*
>=x11-libs/gtk+-2.4.2 )" maybe? 
That said, since gtk+-2.4.1 is the last stable version on most archs, it's
probably not that a good idea.

------- Comment #5 From Ciaran McCreesh 2004-06-22 14:26:02 0000 ------- 
Ok, closing this one off since there's not much we can do about the SEGV... At
some point I'll be upping the gtk+-2 DEPENDs for the eclass for the new file
dialog thingie anyway.

Thanks again for the ebuild.