| Summary: | app-emulation/xen-4.5.0_rc4 USE=efi - Failed Patch: xen-4.4-efi.patch ! | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Daniel Mannarino <daniel.mannarino> |
| Component: | Current packages | Assignee: | Gentoo Xen Devs <xen> |
| Status: | RESOLVED TEST-REQUEST | ||
| Severity: | normal | CC: | ar, daniel.mannarino, hydrapolic, pageexec |
| Priority: | Normal | Keywords: | PATCH |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
Updated xen efi patch
Xen ebuild adjusted for bumped efi patch |
||
Created attachment 393132 [details]
Xen ebuild adjusted for bumped efi patch
thanks for testing, will fix this while the final 4.5.0 official released This is why conditional patching is bad. Applies for 4.5.0. With Daniel's patch xen 4.5.0 works with efi. xen-4.5.0 still fails with USE="efi" - AFAICS on sources.gentoo.org, the patch wasn't updated. (In reply to Robert Sebastian Gerus from comment #6) > xen-4.5.0 still fails with USE="efi" - AFAICS on sources.gentoo.org, the > patch wasn't updated. and everyone, including jer, see Comment 2. Cut the man some slack. He will fix it or I will. From memory I had to manually remake the efi patch for previous bumps. Sometimes they apply to a bumped sometimes they don't. 24 Jan 2015; Ian Delaney <idella4@gentoo.org> +files/xen-4.5-efi.patch, xen-4.5.0.ebuild: add patch to update for IUSE efi, prepared by D. Mannarino from bug #534570, fixes said bug I'm not sure what is meant by conditional patching being under a cloud here. I would NOT want this patch applied without IUSE efi even if it worked anyway. The problem wasn't being conditional, it was that the Makefile code was changed enough for the patch from the prior version to no longer apply. Leaving open for any further cross testing and can be confirmed post further testing |
Created attachment 393130 [details, diff] Updated xen efi patch Xen 4.5.0RC4 fails to build because the patch in app-emulation/xen/xen-4.4-efi.patch does not cleanly apply. It appears that some paths have changed in xen/Makefile. I've attached a revised patch that allows xen-4.5.0RC4 to build.