Summary: | net-im/turses-0.2.23 version bump | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Alessandro Molari <molari.alessandro> |
Component: | Current packages | Assignee: | No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | jlec, proxy-maint, python |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
turses-0.2.23.ebuild
turses-0.2.23.ebuild test errors |
Description
Alessandro Molari
2014-12-11 19:46:07 UTC
Created attachment 394118 [details]
turses-0.2.23.ebuild
A straightforward version bump of the existing ebuild seems to build and run happily.
Thanks so much :) Can we merge the ebuild in the repository? Could you please send us a PR (https://github.com/gentoo/gentoo-portage-rsync-mirror) I've added the ebuild, did repoman full, created a pull request (https://github.com/gentoo/gentoo-portage-rsync-mirror/pull/132). Are you willing to proxy maintain this? https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers @proxy-maint? Are you in sync with the rsync mirror people? Created attachment 404260 [details]
turses-0.2.23.ebuild
Following the suggestions here: https://github.com/gentoo/gentoo-portage-rsync-mirror/pull/132 I've fixed most of the mistakes: repoman, manifest and merge are ok. The only problem I have is with ebuild turses-0.2.23.ebuild test which fails. For details see the attachment "test errors". Can some one help me? Thanks Created attachment 404262 [details]
test errors
(In reply to Alessandro Molari from comment #7) > Created attachment 404260 [details] > turses-0.2.23.ebuild Could you please update the pullrequest? Comment on attachment 404260 [details] turses-0.2.23.ebuild ># Copyright 1999-2014 Gentoo Foundation ># Distributed under the terms of the GNU General Public License v2 ># $Header: /var/cvsroot/gentoo-x86/net-im/turses/turses-0.2.13-r1.ebuild,v 1.2 2014/08/05 18:34:08 mrueg Exp $ > >EAPI=5 > >PYTHON_COMPAT=( python2_7 ) > >inherit distutils-r1 eutils > >DESCRIPTION="Command line twitter client" >HOMEPAGE="https://github.com/alejandrogomez/turses" >SRC_URI="https://github.com/alejandrogomez/${PN}/archive/v${PV}.tar.gz -> ${P}.tar.gz" > >LICENSE="GPL-3" >SLOT="0" >KEYWORDS="~amd64 ~x86" >IUSE="test" > >DEPEND=" > dev-python/oauth2[${PYTHON_USEDEP}] > dev-python/setuptools[${PYTHON_USEDEP}] > >dev-python/tweepy-2.2[${PYTHON_USEDEP}] > <dev-python/tweepy-3[${PYTHON_USEDEP}] > dev-python/urwid[${PYTHON_USEDEP}] > test? ( > dev-python/mock[${PYTHON_USEDEP}] > dev-python/pytest[${PYTHON_USEDEP}] > dev-python/coverage[${PYTHON_USEDEP}] > dev-python/tox[${PYTHON_USEDEP}] > ) >" > >DOCS=( AUTHORS HISTORY.rst README.rst ) > >python_test() { > esetup.py test run py.test as upstream (https://github.com/dialelo/turses/blob/master/.travis.yml). that should remove your errors. >} ~/cvsPortage/gentoo-x86/net-im/turses $ ebuild turses-0.2.23.ebuild clean tes >>> Source compiled. >>> Test phase: net-im/turses-0.2.23 * python2_7: running distutils-r1_run_phase python_test =============== test session starts ==================================== platform linux2 -- Python 2.7.9 -- py-1.4.26 -- pytest-2.7.0 rootdir: /mnt/gen2/TmpDir/portage/net-im/turses-0.2.23/work/turses-0.2.23, inifile: collected 124 items tests/test_api.py .......................... tests/test_config.py ............. tests/test_core.py .......... tests/test_meta.py ... tests/test_models.py ........................................................... tests/test_session.py .. tests/test_ui.py ...... tests/test_utils.py ..... ============== 124 passed in 1.80 seconds =============================== (In reply to Alessandro Molari from comment #9) > Created attachment 404262 [details] > test errors See: net-im/turses-0.2.23/work/turses-0.2.23/tox.ini: commands = pip install -r {toxinidir}/requirements/dev.txt --use-mirrors --quiet py.test To set a test phase with a tox.ini present a package's source, observe the setting of commands = This tells how the suite is actually run. So in this case, python_test() { esetup.py test doesn't work. Run with either 'py.test' or 'py.test tests' now peruse the dozens of other ebuilds in the python herd and add the || die $msg since py.test is an exe file in the installed system. Now note; ~/cvsPortage/gentoo-x86/net-im/turses $ l /mnt/gen2/TmpDir/portage/net-im/turses-0.2.23/work/turses-0.2.23/docs Makefile conf.py dev images index.rst user There is a whole doc build in the source. Why was this skipped? A doc build is a very standard process. There are many of the python herd in the tree to use as a template. I am 99% sure one will simply drop in and just work. You can update the pr but I request to duplicate the update to the ebuild in attachments here which is what I normally use. Alternatively just a link to the pr Also, for the test phase, dev-python/tox[${PYTHON_USEDEP}] is NOT required. tox is a testrunner used typically by upstream developers and is never used to run testsuites in gentoo. See if you can determine why. dev-python/coverage[${PYTHON_USEDEP}] is not essential but is fine This is the link to the pull request: https://github.com/gentoo/gentoo-portage-rsync-mirror/pull/132 Commented in the pr @ github +*turses-0.2.23 (05 Jun 2015) + + 05 Jun 2015; Justin Lecher <jlec@gentoo.org> +turses-0.2.23.ebuild, + metadata.xml: + Version Bump, bug #532312; thanks Adam Jones and Alessandro Molari for the + ebuild, https://github.com/gentoo/gentoo-portage-rsync-mirror/pull/132 + |