Bug 531610 – toolchain.eclass: Prefix support

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Benda Xu 2014-12-04 02:15:22 UTC]

This is a split from bug 474358 to get Prefix supported in toolchain.eclass.

The Prefix patch found in bug 474358 is rebased to the toolchain.eclass in tree.

Reproducible: Always

[Comment 1 Benda Xu 2014-12-04 02:21:43 UTC]

Created attachment 390896 [details, diff]
toolchain.patch

This patch has 4 main modifications to the eclass,

  * Define ED and EROOT for EAPI 0, 1 and 2.
  * Add ${EPREFIX} to ${PREFIX} and quote the variables.
  * Strip ${EPREFIX} if used with a ebuild helper.
  * call fix_libtool_files.sh by name, because /usr/sbin is in PATH,
    and to eliminate the need to write it ${EPREFIX}/usr/sbin/fix_libtool_files.sh

Thanks,
Benda

[Comment 2 Benda Xu 2016-05-22 03:50:32 UTC]

Ping toolchain team.

[Comment 3 Benda Xu 2016-06-23 00:47:02 UTC]

*** Bug 583432 has been marked as a duplicate of this bug. ***

[Comment 4 Benda Xu 2017-01-07 14:31:54 UTC]

Created attachment 459056 [details, diff]
toolchain.patch

two years has passed and no objections were raised. I am going to commit this patch in 3 days after circulation the patch in the dev mailing list.

[Comment 5 Arfrever Frehtes Taifersar Arahesis 2017-01-07 19:21:10 UTC]

Please divide this patch into separate patches, one for each type of change.
E.g. changes of quoting or ${D}/${DATAPATH} -> ${D}${DATAPATH} are prefix-unrelated.

[Comment 6 Benda Xu 2017-01-09 14:01:18 UTC]

(In reply to Arfrever Frehtes Taifersar Arahesis from comment #5)
> Please divide this patch into separate patches, one for each type of change.
> E.g. changes of quoting or ${D}/${DATAPATH} -> ${D}${DATAPATH} are
> prefix-unrelated.

Thanks. Please refer to

  https://archives.gentoo.org/gentoo-dev/message/8a7ac352cb047567309c70aaf7105305

Just committed in tree.