| Summary: | net-wireless/reaver-1.4-r3 segmentation fault because of a epatch | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Tom Li <biergaizi2009> |
| Component: | Current packages | Assignee: | Oleh Kravchenko <oleg> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | jer, maksbotan, proxy-maint |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
oops, that's mine I dropped that chunk. Use strndup() :) |
New patches was added in net-wireless/reaver-1.4-r3 to fix compile warnings, but one of the patch: reaver-1.4_wps_registrar.patch --- a/wps/wps_registrar.c +++ b/wps/wps_registrar.c @@ -2317,11 +2317,11 @@ /* @@@ Save a copy of the network key and ssid directly to the wps_data structure @@@ */ if(wps->cred.key_len > 0) { - wps->key = strdup(wps->cred.key); + memcpy(wps->key, wps->cred.key, sizeof(wps->cred.key)); } if(wps->cred.ssid_len > 0) { - wps->essid = strdup(wps->cred.ssid); + memcpy(wps->essid, wps->cred.ssid, sizeof(wps->cred.ssid)); } Totally break net-wireless/reaver. wps->key and wps->essid are (char *) pointers. The original strdup() call allocate a new piece of memory, copy the string and return a pointer to it. It is nonsense to copy a string to a pointer. It will cause segmentation fault when we got the correct pin. If replace them to memcpy(), we need to allocate memory by malloc().