Bug 526682

Summary:	app-editors/gvim-9999 - sed script for auto.config.mk should remove auto/config.mk instead?
Product:	Gentoo Linux	Reporter:	Coacher <itumaykin+gentoo>
Component:	Current packages	Assignee:	Vim Maintainers <vim>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---

Description Coacher 2014-10-24 20:56:29 UTC

Hello.

I was fooling around with gvim-9999.ebuild and noticed these lines in src_configure():

# Fix bug 18245: Prevent "make" from the following chain:
# (1) Notice configure.in is newer than auto/configure
# (2) Rebuild auto/configure
# (3) Notice auto/configure is newer than auto/config.mk
# (4) Run ./configure (with wrong args) to remake auto/config.mk
sed -i 's/ auto.config.mk:/:/' src/Makefile || die "Makefile sed failed"
rm -f src/auto/configure
emake -j1 -C src autoconf

Here we replace ' auto.config.mk:' string, but it is nowhere to be found in src/Makefile. It probably should be ' auto\/config.mk:'.

Please fix this if it is not intented behavior.


Reproducible: Always

Comment 1 Coacher 2014-10-24 21:06:59 UTC

This possibly should be fixed in other gvim/vim ebuilds as well.

Comment 2 Tim Harder gentoo-dev

2014-10-26 17:54:25 UTC

Actually that regex works fine since '.' matches any character, but I've made it stricter in recent ebuilds.

Comment 3 Coacher 2014-10-26 17:58:47 UTC

(In reply to Tim Harder from comment #2)
> Actually that regex works fine since '.' matches any character, but I've
> made it stricter in recent ebuilds.

Thanks!