| Summary: | mail-mta/nullmailer-1.13-r4: suspicious use of einstall | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Michał Górny <mgorny> |
| Component: | Current packages | Assignee: | Robin Johnson <robbat2> |
| Status: | RESOLVED FIXED | ||
| Severity: | QA | CC: | jlec, net-mail+disabled |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | suspicious-einstall | ||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | 532622 | ||
| Bug Blocks: | 521420 | ||
+*nullmailer-1.13-r5 (15 Dec 2014) + + 15 Dec 2014; Justin Lecher <jlec@gentoo.org> +nullmailer-1.13-r5.ebuild: + Drop einstall in favour of plain emake, #521552; prepend chmod/chown calls in + pkg_* with ROOT, #532588 + + 05 Jan 2015; Justin Lecher <jlec@gentoo.org> -nullmailer-1.13-r4.ebuild: + Drop old, obsoletes #521552 & #532588 + |
Please check whether the use of 'einstall' in this ebuild is actually needed. From a quick glance at the Makefile, it seems to have proper support for DESTDIR. Therefore, if possible please replace the call to 'einstall' with proper 'default' or 'emake DESTDIR="${D}" install'. Thanks.