| Summary: | net-p2p/{bitcoin-qt,bitcoind}-0.9.2.1: suspicious use of einstall | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Michał Górny <mgorny> |
| Component: | Current packages | Assignee: | Luke-Jr <luke-jr+gentoobugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | QA | CC: | blueness, proxy-maint |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | suspicious-einstall | ||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 521420 | ||
(merging into one since both packages seem to use the same distfile) I switched to `emake DESTDIR="${D}" install`. There's not reason to use einstall.
@Luke-jr. We've now made numerous small changes to the bitcoin ebuilds on the tree. You'll want to back port them to the overlay so the next time I copy over the next bumps, I would have to make sure these changes were lost.
|
Please check whether the use of 'einstall' in this ebuild is actually needed. From a quick glance at the Makefile, it seems to have proper support for DESTDIR. Therefore, if possible please replace the call to 'einstall' with proper 'default' or 'emake DESTDIR="${D}" install'. Thanks.