Summary: | sys-kernel/genkernel-3.4.49.2: fails to build due to stray epatch_user call | ||
---|---|---|---|
Product: | Gentoo Hosted Projects | Reporter: | Patrick Lauer <patrick> |
Component: | genkernel | Assignee: | Gentoo Genkernel Maintainers <genkernel> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | axs |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
Patrick Lauer
2014-06-21 05:10:26 UTC
Ian asked me if he could add epatch_user to the ebuild. I thought he wanted to add `epatch_user` to the ebuild, so I said yes. Instead he added `epatch_user || die`, which caused this. I am at fault for approving the change without doing proper review. I have fixed the ebuilds to be what I thought Ian had asked me to commit, which resolves this bug. That being said, there is still the matter of the breakdown in discipline that allowed this to happen in the first place. I take full responsibility for that and it will not happen again. From now on, I will insist that all non-genkernel developers send diffs containing changes to genkernel developers for review. The sole exception shall be keywording. Even trivial modifications like epatch_user will require review. Yes, I apologize too for messing things up. I was not aware that epatch_user was ||die exempt on EAPIs prior to 4, and I should have checked this prior to committing. |