Hi, I commited the ebuild to CVS. Your ebuild looks quite tidy
and plain, but there are several flaws in your ebuild.
* You need to inherit eutils if you use epatch. epatch can be
used without it but you are strongly advised to inherit it.
* LICENSE is not GPL but GNU EMACS GENERAL PUBLIC LICENSE.
I committed it as Emacs. (If you are going to submit another
package that needs some license files other than one from
/usr/portage/licenses, it is a good idea to write so)
* sys-apps/sed is not usually necessary for runtime, so it should
be removed from RDEPEND.
* myconf="`use_enable canna`" won't work. It will be expanded as
--enable-canna and --disable-canna depending on what USE flag
you have, but some configure scripts are broken so that
--disable-canna means --enable-canna (e.g. im-ja's configure
script is such). I changed that part to
if use canna; then
myconf="--enable-canna"
fi
(no --enable-canna nor --disable-canna means you don't want to
enable canna support). You need to actually check each USE flag
if you add one.
* "into" and "dodir" aren't necessarry. Portage defaults to
"into /usr" (see man 5 ebuild) and insinto automatically creates
target directory.
Anyhow, thanks for submitting the ebuild. Keep in touch with
Bugzilla! ;)
