Summary: | app-arch/sharutils-4.14 fails tests/shar-3 - fserr 22 (Invalid argument) performing 'popen' on [...] | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Jeroen Roovers (RETIRED) <jer> |
Component: | [OLD] Core system | Assignee: | Gentoo's Team for Core System packages <base-system> |
Status: | RESOLVED FIXED | ||
Severity: | normal | Keywords: | TESTFAILURE |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
tests/shar-3.log
Remove the popen patch |
Description
Jeroen Roovers (RETIRED)
2014-03-13 18:53:51 UTC
Attaching a patch which disables the 4.14 patch (files/sharutils-4.14-popen-rb.patch). I can reproduce the failure. The popen patch forces an illegal "rb" option to popen (should be "r", see man 3 popen), which breaks not only the tests, but breaks the shar utility itself. I see nothing in bugzilla that explains the purpose of the popen patch. Removing it causes all tests to pass as expected. Created attachment 372830 [details, diff]
Remove the popen patch
Comment on attachment 372830 [details, diff]
Remove the popen patch
this simply reintroduces the previous error that the patch was fixing
also, don't post diffs to Manifest files ... that's just noise
should be all set now in the tree; thanks for the report! Commit message: Fix inverted logic in popen binary patch http://sources.gentoo.org/app-arch/sharutils/files/sharutils-4.14-popen-rb.patch?r1=1.1&r2=1.2 http://sources.gentoo.org/app-arch/sharutils/sharutils-4.14-r1.ebuild?rev=1.1 |