Summary: | kde-misc/networkmanagement-0.9.0.10 fails to build with >=net-misc/openconnect-5.99 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Zoltan Puskas <zoltan> |
Component: | [OLD] KDE | Assignee: | Gentoo KDE team <kde> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | dschridde+gentoobugs, lamarque, tetromino |
Priority: | Normal | Keywords: | PMASKED |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://bugs.gentoo.org/show_bug.cgi?id=504192 | ||
Whiteboard: | removal on 2014/05/14 | ||
Package list: | Runtime testing required: | --- | |
Attachments: |
Build log
Quick patch to the new API of openconnect |
Description
Zoltan Puskas
2014-03-08 20:32:42 UTC
Created attachment 372114 [details]
Build log
It seems the problem is caused by an API change in the openconnect package. See git commit: http://git.infradead.org/users/dwmw2/openconnect.git/commitdiff/9d660c6c118a9f19acad81af8340d455bf775348 Created attachment 372122 [details, diff]
Quick patch to the new API of openconnect
This patch is to build kde-misc/networkmanagement-0.9.0.10 against net-misc/openconnect-5.99.
Take a look at how networkmanager handles both the old and new openconnect API in the same source: https://git.gnome.org/browse/network-manager-openconnect/tree/auth-dialog/main.c?h=nm-0-9-8 #if OPENCONNECT_CHECK_VER(3,0) #define NEWGROUP_SUPPORTED 1 #define AUTHGROUP_OPT(form) (void *)(form)->authgroup_opt #define AUTHGROUP_SELECTION(form) (form)->authgroup_selection #define FORMCHOICE(sopt, i) ((sopt)->choices[i]) #define IGNORE_OPT(opt) ((opt)->flags & OC_FORM_OPT_IGNORE) #else #define NEWGROUP_SUPPORTED 0 #define AUTHGROUP_OPT(form) NULL #define AUTHGROUP_SELECTION(form) 0 #define FORMCHOICE(sopt, i) (&(sopt)->choices[i]) #define IGNORE_OPT(opt) 0 #define OC_FORM_RESULT_ERR -1 #define OC_FORM_RESULT_OK 0 #define OC_FORM_RESULT_CANCELLED 1 #define OC_FORM_RESULT_NEWGROUP 2 #endif Probably networkmanagement should introdice something like this FORMCHOICE macro. networkmanagement is deprecated upstream so there probably won't be much activity there. The sucessor, plasma-nm, has a patch that might be of interest though: http://quickgit.kde.org/?p=plasma-nm.git&a=commit&h=947f56f1cd21a72fa0f88e1c42ac8c19e23864d0 @Lamarque As you are the upstream maintainer, could you provide a patch? I can port the patch in comment #5 to networkmanagement and release Plasma NM 0.9.0.11 (there are some other commits that are queued for the next release already). I do not have an openconnect server that I can test the patch and finish the OC_FORM_RESULT_NEWGROUP implementation though. I hit this build failure and move to kde-misc/plasma-nm (In reply to Lamarque V. Souza from comment #7) > I can port the patch in comment #5 to networkmanagement and release Plasma > NM 0.9.0.11 (there are some other commits that are queued for the next > release already). I do not have an openconnect server that I can test the > patch and finish the OC_FORM_RESULT_NEWGROUP implementation though. @Lamarque Thanks for your fast response, we have stabilized plasma-nm in the meanwhile. Do you think we should just "last rite" networkmanagement as plasma-nm is the successor? Yes, it makes sense. I already deprecated networkmanagement and will release new versions only on distributions request during the transition to plasma-nm. There has been no new feature in Plasma NM 0.9.0.x series for quite some time, just bugfixing. (In reply to Lamarque V. Souza from comment #10) > Yes, it makes sense. I already deprecated networkmanagement and will release > new versions only on distributions request during the transition to > plasma-nm. There has been no new feature in Plasma NM 0.9.0.x series for > quite some time, just bugfixing. Why to deprecate networkmanagement? Its interface is much better, imho, and I don't see anything that plasma-nm can do better or that networkmanagement can't do while plasma-nm can. (In reply to Denis Sokolovsky from comment #11) > Why to deprecate networkmanagement? Its interface is much better, imho, and > I don't see anything that plasma-nm can do better or that networkmanagement > can't do while plasma-nm can. networkmanagement is officially Plasma NM <= 0.9.0.x, plasma-nm is Plasma NM >= 0.9.8.x. They are developed by the same developers and plasma-nm is the evolution of networkmanagement. The source code of plasma-nm is smaller, cleaner and easier to maintain. Those alone are good reasons to deprecate networkmanagement. plasma-nm interface also takes less space on the screen (a constant complaint about networkmanagement), is more touchscreen friendly (that is usefull for Plasma Active) and it indeed supports some features not present in networkmanagement like: . manual wifi scanning. . activate a connection (for example vpn) when another connection is activated (wifi, wired, etc). . supports other connection types, such as wimax, bond, bridge and vlan. plasma-nm also has better integration with Bluedevil, the bluetooth management software for KDE, when creating bluetooth connections. There is no interest from KDE developers in continuing developing networkmanagement, so I strongly advise everybody to move to plasma-nm. I can still make a final release of Plasma NM 0.9.0.x series upon distributions' request. However, there has been no interested in that so far. (In reply to Lamarque V. Souza from comment #12) > I can still make a final release of Plasma NM 0.9.0.x series upon > distributions' request. However, there has been no interested in that so far. I'd be interested in that. :-) > I can still make a final release of Plasma NM 0.9.0.x series upon
> distributions' request. However, there has been no interested in that so far.
Yes, I'm interested too. Plasma-nm does not play well with corporate VPN with certificates, however networkmanagement works fine. Worst case I will create an overlay and keep this package alive there until plasma-nm is fixed.
(In reply to Zoltan Puskas from comment #14) > > I can still make a final release of Plasma NM 0.9.0.x series upon > > distributions' request. However, there has been no interested in that so far. > > Yes, I'm interested too. Plasma-nm does not play well with corporate VPN > with certificates, however networkmanagement works fine. Worst case I will > create an overlay and keep this package alive there until plasma-nm is fixed. Have you reported this issue to bugs.kde.org? If not then please do it, this is a kind of show stopper issue. I will release Plasma NM 0.9.0.11 today then. (In reply to Lamarque V. Souza from comment #15) > I will release Plasma NM 0.9.0.11 today then. Thank you! I've added it to the tree. *networkmanagement-0.9.0.11 (23 Apr 2014) 23 Apr 2014; Manuel Rüger <mrueg@gentoo.org> +networkmanagement-0.9.0.11.ebuild, networkmanagement-0.9.0.10-r1.ebuild, networkmanagement-0.9.0.10.ebuild: Version bump. Fixes bug #503898. Restrict to <net-misc/openconnect-5.99 on earlier versions. |