Summary: | net-fs/netatalk-3.0.5 generates incorrect netatalk.service for systemd | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Sergey Galkin <sergey.gals> |
Component: | Current packages | Assignee: | Justin Lecher (RETIRED) <jlec> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | net-fs |
Priority: | Normal | Keywords: | PATCH |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
URL: | https://sourceforge.net/p/netatalk/bugs/536/ | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 480076 |
Description
Sergey Galkin
2013-10-31 18:20:09 UTC
I think the lock/PID file should be moved to /run/lock. I don't have a /var/lock, but I do have a /run/lock. /run/lock get wiped out during reboots, which is a plus. --- /usr/portage/net-fs/netatalk/netatalk-3.0.5.ebuild 2013-10-19 17:31:24.000000000 -0400 +++ netatalk-3.0.5-r1.ebuild 2013-11-01 17:08:41.121043485 -0400 @@ -100,6 +100,7 @@ --with-uams-path=/usr/$(get_libdir)/${PN} --disable-silent-rules --with-init-style=gentoo + --with-lockfile=/run/lock/${PN} ) autotools-utils_src_configure } @@ -120,6 +121,8 @@ sed \ -e "s|:SBINDIR:|${EPREFIX}/usr/sbin|g" \ distrib/initscripts/service.systemd.tmpl \ + | sed \ + -e "s|:PATH_NETATALK_LOCK:|/run/lock/netatalk|g" \ > "${T}"/service.systemd || die systemd_newunit "${T}"/service.systemd ${PN}.service you are right. I think it happens, because we are using the --with-init-style=gentoo and not --with-init-style=systemd. I will look into that. +*netatalk-3.0.5-r1 (02 Nov 2013) + + 02 Nov 2013; Justin Lecher <jlec@gentoo.org> -netatalk-3.0.5.ebuild, + +netatalk-3.0.5-r1.ebuild: + Fix borked systemd unit, #489990 + Thanks for the patches guys. Hopefully upstream will allow multiple init systems in parallel for the next version. |