Bug 489980

Summary:	>=net-misc/dhcp-4.0: PEER_DNS patches break generation of resolv.conf due to syntax error (bashism)
Product:	Gentoo Linux	Reporter:	Aleksandr Karagodov <skar666>
Component:	[OLD] Core system	Assignee:	Gentoo's Team for Core System packages <base-system>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---

Description Aleksandr Karagodov 2013-10-31 15:39:23 UTC

Gentoo patches "dhcp-4*-dhclient-resolvconf.patch" and "dhcp-4.2.5-iproute2-path.patch" have a syntax error at this line:

+  if [ x"$PEER_DNS" != x ] && [ x$"PEER_DNS" != xyes ]; then

This causes dhclient-script to fail to produce resolv.conf whenever PEER_DNS is set to anything.

Comment 1 SpanKY gentoo-dev

2013-11-28 20:00:54 UTC

bash would handle it as expected, but if your /bin/sh is not bash, then it'll probably fail w/a syntax error

Comment 2 SpanKY gentoo-dev

2013-11-28 20:03:57 UTC

should be all set now in the tree; thanks for the report!

Commit message: Fix syntax error in PEER_DNS patches
http://sources.gentoo.org/net-misc/dhcp/files/dhcp-4.2.1-dhclient-resolvconf.patch?r1=1.1&r2=1.2
http://sources.gentoo.org/net-misc/dhcp/files/dhcp-4.2.2-dhclient-resolvconf.patch?r1=1.1&r2=1.2
http://sources.gentoo.org/net-misc/dhcp/files/dhcp-4.2.5-iproute2-path.patch?r1=1.1&r2=1.2