Bug 48960 - [update] app-vim/cream-0.29
Bug#: 48960 Product:  Gentoo Linux Version: unspecified Platform: All
OS/Version: All Status: RESOLVED Severity: enhancement Priority: P2
Resolution: FIXED Assigned To: ciaran.mccreesh@googlemail.com Reported By: tom.gl@free.fr
Component: Ebuilds
URL:  http://cream.sourceforge.net/changelog.html
Summary: [update] app-vim/cream-0.29
Keywords:  EBUILD
Status Whiteboard: 
Opened: 2004-04-25 12:09 0000
Description:   Opened: 2004-04-25 12:09 0000 
Hi,

Cream 0.29 has been released.  I've made a few changes to the ebuild: 
 - added the optionnal spell dicts from this page: 
   http://cream.sourceforge.net/spellcheck.html
   This depends on the "spell" USE flag and LINGUAS variable (see 
   explanations in the ebuild).
 - changed "ctags" for "exuberant-ctags" where needed, and added an 
   rdep on dev-utils/ctags
 - added .desktop file and icon
 - fixed a new bug that prevents creation of user's dirs (~/.cream and 
   its subdirs) because of a slash/backslash confusion

Note that for some reason, i get a lot of assert warnings from glib when i close Cream (namely some "file gobject.c: line 1579 (g_object_unref): assertion `G_IS_OBJECT (object)' failed"). It seems to work fine despite of that (this is on as up-to-date ~x86 system, using gvim-6.2-r8 and glib-2.4.0).

------- Comment #1 From TGL 2004-04-25 12:09:55 0000 ------- 
Created an attachment (id=30031) [details]
cream-0.29.ebuild

------- Comment #2 From TGL 2004-04-25 12:10:35 0000 ------- 
Created an attachment (id=30032) [details]
files/cream-0.29--gentoo.patch

------- Comment #3 From Ciaran McCreesh 2004-04-26 06:38:02 0000 ------- 
Thanks. I'm afraid I might not be able to look at this properly until tomorrow
-- I'm not ignoring you, I just don't multitask very well :) Sorry...

------- Comment #4 From TGL 2004-04-28 11:54:34 0000 ------- 
Don't worry, there's no hurry. It usually takes me more than one month before i
start feeling ignored. :)

About the glib warnings i've mentionned above, it is definitely not a Cream
bug, but more a GVim (or maybe Gtk-2.4) one. I've reported an attempt of
fix/workaround on vim-dev:
http://marc.theaimsgroup.com/?l=vim-dev&m=108317705302808

------- Comment #5 From TGL 2004-04-28 21:31:03 0000 ------- 
I just realized that in fact cream has been bumped in portage 2 days after i
opened this bug. :)

wmertens, i CC you since you made this bump, in case you want to integrate some
of the changes/fix from my version. At least the ctags fix is needed. Also,
more patching of INSTALL.sh is needed if you want to use it instead of an
src_install rewrite: currently, it install cream in vim62, but vim-6.3 beta
will come soon, and would break existing cream installations.

------- Comment #6 From Ciaran McCreesh 2004-04-28 23:07:00 0000 ------- 
0.29 as-is pulled from the tree, as it is broken. 0.29-r1 added in as ~arch.

I made a few changes to the contributed ebuild:

* Don't use the spell? flag. We're not altering the installed app, so we shouldn't be using flags here.
* Split the patches up into three to make them a bit more maintainable.
* Change the src_unpack logic a bit.
* Add in a flashy info about LINGUAS.

I'm not using INSTALL.sh because it's not even remotely destdir-aware. Although it doesn't matter for now, it could very easily create subtle but nasty errors in the future.

Cheers.

------- Comment #7 From TGL 2004-04-29 06:32:54 0000 ------- 
Thanks Ciaran for this changes, they're all good. 

There's just a small error in pkg_postinst:
  /usr/sbin/ebuild.sh: line 76: [: too many arguments

Patch:
- if [ -z ${LINGUAS} ] ; then
+ if [ -z "${LINGUAS}" ] ; then

------- Comment #8 From Ciaran McCreesh 2004-04-29 08:17:43 0000 ------- 
D'oh! Strange no-one noticed that, enough people looked over the ebuild :)
Fixed, cheers.