Bug 486192

Summary:	[kde overlay] kde-misc/plasma-nm - make modemmanager support optional
Product:	Gentoo Linux	Reporter:	Elias Probst <mail>
Component:	[OLD] KDE	Assignee:	Gentoo KDE team <kde>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	https://bugs.kde.org/show_bug.cgi?id=319197
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	486812
Attachments:	Patch to make modemmanager in plasma-nm optional Patch to make modemmanager in plasma-nm optional

Description Elias Probst 2013-09-27 14:24:05 UTC

Now that KDEBUG#319197 (https://bugs.kde.org/show_bug.cgi?id=319197) is solved, this change needs to be applied to kde-misc/plasma-nm by making this dependent on the 'modemmanager' USE flag.

Comment 1 Johannes Huber (RETIRED) gentoo-dev

2013-09-27 17:35:09 UTC

The current cmake check for net-libs/libmm-qt is done in automagic way. Upstream have to provide a build option for this first. This is also true for net-libs/libnm-qt, which checks for net-libs/libmm-qt too.

Please re-open when upstream provides the build option

Comment 2 Elias Probst 2013-10-01 09:51:56 UTC

Looks like plasma-nm can now be built without libmm-qt: http://quickgit.kde.org/?p=plasma-nm.git&a=blobdiff&h=dbbdf42e9cce928e6824b126b37b9614069ed099&hp=f10f7f9bfd2ae7501d7ff44819a9c42b47638c5c&hb=0718c5c8c3f5a81023480a89bc293590bcb4f1ff&f=CMakeLists.txt

Comment 3 Elias Probst 2013-10-01 10:29:34 UTC

Created attachment 359860 [details, diff]
Patch to make modemmanager in plasma-nm optional

Looks like I didn't succeed to get this working…

cmake is run with "-DDISABLE_MODEMMANAGERQT=ON", but it still enabled modemmanager:

-- checking for module 'ModemManagerQt'
--   found ModemManagerQt, version 0.7.991
-- Enabling ModemManager support


Did I do something wrong or upstream?

Comment 4 Elias Probst 2013-10-01 12:31:32 UTC

Created attachment 359866 [details, diff]
Patch to make modemmanager in plasma-nm optional

There was another upstream commit shortly after my 1st attempt:

https://projects.kde.org/projects/playground/network/plasma-nm/repository/revisions/193f498ddf250ca4b1776ce13e22e9581962bac1/diff

The attached patch works for me.

Comment 5 Johannes Huber (RETIRED) gentoo-dev

2013-10-13 13:22:20 UTC

Thanks for reporting. Modemmanager support is now optional by upstream. Ebuilds changed. This has been fixed for live version. Please sync.

net-libs/libnm-qt:
http://git.overlays.gentoo.org/gitweb/?p=proj/kde.git;a=commit;h=f0ec8e8a8408e989c993bb0b4eed27e8f4f80800

kde-misc/plasma-nm:
http://git.overlays.gentoo.org/gitweb/?p=proj/kde.git;a=commit;h=740b81d51b12060bb80c6d5c74953682f2c792fb