| Summary: | net-nds/phpldapadmin - broken with php-5.5 | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | masc <masc> |
| Component: | [OLD] Server | Assignee: | Víctor Ostorga (RETIRED) <vostorga> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | alexanders83, dschridde+gentoobugs, ironiridis, jmbsvicetto, mail, web-apps |
| Priority: | Normal | Keywords: | PATCH |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://bugzilla.redhat.com/show_bug.cgi?id=974928 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
Paweł Tomulik's Patch
upstream patch for building with PHP5.5 patch for ebuild ebuild for 1.2.3-r1 fix password_hash function redefine fix warning about preg_replace /e switch Add PHP version dep for existing 1.2.3 update patch to use pla prefix, include two more locations |
||
|
Description
masc
2013-08-24 17:38:52 UTC
Which version of phpldapadmin is broken? All of them? 1.2.2 and 1.2.3 for sure. basically any version declaring the function password_hash in lib/functions.php. I can confirm this bug. Paweł Tomulik posted a patch @Debian Bug Repots http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=710854 I've successfully tested it with dev-lang/php-5.5.2 and net-nds/phpldapadmin-1.2.3 I'll attach his patch Created attachment 357568 [details, diff]
Paweł Tomulik's Patch
On their mailinglist another patch appeared: http://sourceforge.net/mailarchive/message.php?msg_id=31302386 http://sourceforge.net/u/nihilisticz/phpldapadmin/ci/7e53dab990748c546b79f0610c3a7a58431e9ebc/ (In reply to Dennis Schridde from comment #5) Attachment #357568 [details, diff] is definitely not sufficient: Error E_WARNING: password_hash() expects parameter 2 to be long, string given From: lib/PageRender.php (290) Created attachment 370938 [details, diff]
upstream patch for building with PHP5.5
Created attachment 370940 [details, diff]
patch for ebuild
I've added 2 patched adding the patch from upstream (http://sourceforge.net/u/nihilisticz/phpldapadmin/ci/7e53dab990748c546b79f0610c3a7a58431e9ebc/). This fixes the problem for me. Can we block <=net-nds/phpldapadmin-1.2.3 with >=dev-lang/php-5.5, and ship these patches from http://sourceforge.net/u/nihilisticz/phpldapadmin/ci/7e53dab990748c546b79f0610c3a7a58431e9ebc/ as -1.2.3-r1 ? Created attachment 373756 [details]
ebuild for 1.2.3-r1
Created attachment 373758 [details, diff]
fix password_hash function redefine
Created attachment 373760 [details, diff]
fix warning about preg_replace /e switch
Created attachment 373762 [details, diff]
Add PHP version dep for existing 1.2.3
(In reply to Christohper Harrington from comment #10) > Can we block <=net-nds/phpldapadmin-1.2.3 with >=dev-lang/php-5.5, and ship > these patches from > http://sourceforge.net/u/nihilisticz/phpldapadmin/ci/ > 7e53dab990748c546b79f0610c3a7a58431e9ebc/ as -1.2.3-r1 ? sure, 1.2.3 is the way forward. I wouldn't see a reason to stick with an older version anyhow, as they are all in unstable/testing. Created attachment 373766 [details, diff]
update patch to use pla prefix, include two more locations
Previous patch defined password_hash_custom, but convention says a prefix is more future-proof than a suffix. Use pla_* rather than *_custom. Also previous patch missed two locations where the password_hash function was being referenced.
What is the next step here? There's an ebuild file and patches. Can this be confirmed? Or can someone send me a link to the process for committing this to portage and assign this bug to me? Can this bug be reassigned? I've committed 1.2.3-r1 to my overlay. I'll add it to the tree later when I get home. 01:36 < irker869> gentoo-x86: jmbsvicetto net-nds/phpldapadmin: Add a patch to allow phpldapadmin to build against php-5.5. Bump to EAPI 5. Fixes bug 482340 - thanks to Alexander Stein. Done. |
