Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 481962

Summary: >=x11-wm/openbox-3.5.2 missing dependency and useflag svg
Product: Gentoo Linux Reporter: Julian Ospald <hasufell>
Component: New packagesAssignee: Markos Chandras (RETIRED) <hwoarang>
Status: RESOLVED FIXED    
Severity: normal CC: desktop-wm+disabled, droshalla, jrmalaq, lxde+disabled
Priority: Normal Keywords: InVCS
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 481922    
Attachments: openbox-3.5.2-r1.ebuild.diff
metadata.xml.diff

Comment 1 Julian Ospald 2013-08-21 14:06:45 UTC
Created attachment 356590 [details, diff]
openbox-3.5.2-r1.ebuild.diff

* migrate to python-r1
* use 'xdg' instead of 'python' useflag for xdg-autostart support since this has nothing to do with "python support" in any way
* order dependencies alphabetically
* add missing svg useflag and dependency on gnome-base/librsvg:2
* remove --disable-silent-rules since it's part of EAPI=5
* use prune_libtool_files
* improve readability, use less tokens, improve error handling
Comment 2 Julian Ospald 2013-08-21 14:08:18 UTC
Created attachment 356596 [details, diff]
metadata.xml.diff
Comment 3 Julian Ospald 2013-08-21 14:10:03 UTC
also note: multilib.eclass inherit could be dropped now
Comment 4 Julian Ospald 2013-08-21 14:52:32 UTC
I forgot:

* ordered econf args by `./configure --help` output
Comment 5 Markos Chandras (RETIRED) gentoo-dev 2013-08-24 23:34:53 UTC
Thanks for the patch. However, please run repoman full next time. the python use flag can't be removed from metadata.xml since it's used by old ebuilds. The patch merged with a few changes to update -9999 ebuild as well and use a common one for future version bumps.

+*openbox-3.5.2-r1 (24 Aug 2013)
+
+  24 Aug 2013; Markos Chandras <hwoarang@gentoo.org> +openbox-3.5.2-r1.ebuild,
+  openbox-9999.ebuild, metadata.xml:
+  Add missing useflag and dependency to librsvg. Rework ebuild and migrate
+  to python-r1. Rename xdg->python. Sync 9999 ebuild and use a common
+  ebuild for releases and git versions. Thanks to Julian Ospald
+  <hasufell@gentoo.org> for the fixes on bug #481962
+