Bug 480302 – net-nntp/sabnzbd-0.7.14 with app-arch/par2cmdline-0.4-r2 - bad command line options in sabnzbd/newsunpack.py

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description dcb 2013-08-09 01:49:33 UTC]

If a downloaded file fails the rar check, sabnzbd should download available par2 files to repair the archive.  It doesn't, however, because sabnzbd is passing parameters to par2cmdline that cause it to produce an error message and then none of the par2s are downloaded.

This problem is documented in the sabnzbd forums:

http://forums.sabnzbd.org/viewtopic.php?f=2&t=14585
http://forums.sabnzbd.org/viewtopic.php?t=13872
http://forums.sabnzbd.org/viewtopic.php?f=2&t=13124

From the one post:

I have verified that my issue is with the par2cmdline which was installed. My system is gentoo and the par2cmdline-0.4-r2.ebuild had a patch which only pertained to par2 wildcard expansion that only worked on creating par2 files, not verify nor repair. I have submitted a request to the gentoo to get this resolved for the ebuild.

And here's the bug:

https://bugs.gentoo.org/show_bug.cgi?id=474540



Reproducible: Always

[Comment 1 dcb 2013-08-10 02:50:17 UTC]

I found a patch in the sabnzbd forums that gets sabnzbd working again with par2cmdline currently in portage.

[I] net-nntp/sabnzbd
     Available versions:  (~)0.7.13-r2 (~)0.7.14 {{+rar +ssl unzip +yenc}}
     Installed versions:  0.7.14(09:13:21 08/08/13)(rar ssl yenc -unzip)
     Homepage:            http://www.sabnzbd.org/
     Description:         Binary newsgrabber with web-interface

[I] app-arch/par2cmdline
     Available versions:  0.4-r2
     Installed versions:  0.4-r2(05:21:32 08/09/13)
     Homepage:            http://parchive.sourceforge.net/
     Description:         A PAR-2.0 file verification and repair tool

+--- sabnzbd/newsunpack.py.orig  2013-07-07 13:29:12.000000000 +0200
++++ sabnzbd/newsunpack.py  2013-08-02 20:16:22.286697000 +0200
+@@ -966,7 +966,7 @@
+ 
+     # Append the wildcard for this set
+     wildcard = '%s*' % os.path.join(os.path.split(parfile)[0], setname)
+-    if single or len(globber(wildcard, None)) < 2:
++    if len(globber(wildcard, None)) < 2:
+         # Support bizarre naming conventions
+         wildcard = os.path.join(os.path.split(parfile)[0], '*')
+     command.append(wildcard) 

As you can see, it's only a 1 line change.  I just tried it out with a nzb that needed par2 corrections and with this patch sabnzbd was working correctly again.

[Comment 2 Joe Kowalski 2013-09-02 18:07:33 UTC]

+1 on this patch. SAB now properly downloads additional parity files to complete broken downloads.

[Comment 3 Fab 2013-09-17 21:07:58 UTC]

Confirming.

Also, newest 0.7.16 seems also affected.

[Comment 4 Justin Bronder (RETIRED) 2013-10-08 23:20:22 UTC]

+*sabnzbd-0.7.16 (08 Oct 2013)
+
+  08 Oct 2013; Justin Bronder <[e-mail]> -sabnzbd-0.7.13-r2.ebuild,
+  -sabnzbd-0.7.14.ebuild, +sabnzbd-0.7.16.ebuild, +files/par2cmdline.patch,
+  files/sabnzbd.initd, -files/sabnzbd.logrotate:
+  Version bump and remove old (#484226). Fix initd script thanks to eponymous
+  (#483786). Remove logrotate (#483672). Fix issues with stable version of
+  par2cmdline thanks to dcb (#480302).