Home | Docs | Forums | Lists | Bugs | Planet | Store | GMN | Get Gentoo!

Full Text Bug Listing

The configure script for filelight supports --without-arts option, but the
ebuild doesn't. See attached ebuild, which remedies this problem.

I am not sure if this is the right way:
This ebuild inherits kde-base, so it has kde_src_compile() already. I've
written a replacement src_compile() function which takes "arts" USE flag into
account. Is there any way to re-use the original kde_src_compile() and honor
mentioned USE flag at once?

Created an attachment (id=29291) [details]
A modified ebuild file for filelight

- kde-base is deprecated, use kde instead
- the ebuild header is invalid:
http://www.gentoo.org/doc/en/ebuild-mistakes.xml

Created an attachment (id=29296) [details]
A modified ebuild for filelight

Sorry about the header, I just copied and modified the existing ebuild.

I forgot to add that filielight works perfectly even when not using *_compile()
function from kde.eclass.

> I forgot to add that filielight works perfectly even when not using *_compile()
function from kde.eclass.

Oh, overlooked that. It will fail because of sandbox problems, when having
userpriv in features. Please replace the econf/emake lines with
"kde_src_compile all". Also the eclass sets a lot of other options, so it isn't
acceptable not to use the inherited function, when inheriting the kde.eclass.

That's what I've been asking in my original comment for this bug - how to honor
"arts" USE flag and use functions from kde.eclass at the same time?

Just set myconf as you like and call "kde_src_compile all" afterwards. The
function appends a few other options, but doesn't overwrite myconf.

Created an attachment (id=29431) [details]
A fixed ebuild for filelight 0.6.4.1

Thanks for the advice, I now know how to re-use inherited functions :)

I forgot to write, that I have included an usable (hopefully) version of
ebuild.

A few annotations Andrej: 
- just remove the '&& myconf="${myconf}"' part
- the devs probably wouldn't consider this a -r1, but a silent ebuild update (i could be wrong, though)
- don't lose patience, sometimes these minor ebuild fixes need a while until they get commited

Created an attachment (id=29506) [details]
An ebuild file for filelight 0.6.4-1

Thanks for suggestions, I've fixed the ebuild according to the first one. Let
devs express their opinion about the ebuild name.

A great program, very handy.  Apr 17th ebuild works perfectly, ready for
portage?

Yes, pretty ready, I think. We've straightened out all quirks by now.

committed - thanks for ebuild.