Bug 47447 - bluefish-0.13 (version bump)
|
Bug#:
47447
|
Product: Gentoo Linux
|
Version: unspecified
|
Platform: x86
|
|
OS/Version: Linux
|
Status: RESOLVED
|
Severity: enhancement
|
Priority: P2
|
|
Resolution: FIXED
|
Assigned To: hanno@gentoo.org
|
Reported By: athemis@ish.de
|
|
Component: Ebuilds
|
|
|
URL:
|
|
Summary: bluefish-0.13 (version bump)
|
|
Keywords:
|
|
Status Whiteboard:
|
|
Opened: 2004-04-10 11:31 0000
|
Version bump to 0.13
Renaming the old ebuild to bluefish-0.13.ebuild works fine.
Reproducible: Always
Steps to Reproduce:
1.
2.
3.
There is no need to include a .ebuild if a bump is all that is required.
Renaming bluefish-0.12.ebuild to bluefish-0.13.ebuild doesn't work for me!
Installation fails with ACCESS DENIED for some files. I made new ebuild and one patch.
New ebuild is little simplified, because of the patch and also bluefish developers fixed creation of bluefish.desktop file.
The patch is not gentoo specific and I'm going to mail it to bluefish team.
Created an attachment (id=30122) [details]
Updated patch for bluefish-0.13 DESTDIR build problems
Jan,
I was looking through your patch and whilst the new ebuild all looks good (well
done by the way, it really looks a lot simpler), I noticed that your patch does
not fix the underlying problem with their Makefiles, but only fixes it such
that it will install under gentoo.
The actual problem is that they check for the existance of $(blah), for
example, but then attempt to install the file into $(DESTDIR)$(blah). Your
patch creates $(DESTDIR)$(blah) if it does not exist which will work, but
presumably a better patch is to alter the test to check whether the correct
directory exists?
I've attached another candidate patch but haven't submitted this to the end
developers (just in case I'm wrong)... 5:)
Mike: Using your ebuild and patch, bluefish-0.13 is _merged_ to
$(PORTAGE_TMPDIR)/bluefish-0.13/image/usr/[...]
Created an attachment (id=32015) [details]
bluefish-0.13-r1.ebuild - einstall problem fixed
Hmmmm
You're quite right, it does seem to install into
/var/tmp/portage/bluefish-0.13/image/, but also into /. It installs the
binaries and translation files once into the .../image directory, and then
installs everything (translation, binary and images) in /.
My understanding was that portage calls configure and tells it various
directories, substituting things like /var/tmp/portage/blah/image/ for / and
others. The make install scripts then install to $DESTDIR (which because of
the configure scripts is now the .../image directory). Finally once the image
directory is correctly made, that gets merged into the actual root.
It's probably a problem in the ebuild, since my patch only modifies directory
existance checks. Lemme take a look...
Ok, it turns out that during the cleanup, Jan must've accidentally left it
using einstall rather than make install. The problem being that we set DESTDIR
(as is preferred practice) and then einstall jiggers all the internal variables
too (making it put files in DESTDIR/.../image/blah, which of course is
.../image/.../image/blah). This is easily fixed by using the (preferred) make
install DESTDIR=${D} line, and this should now work.
Thanks a lot for the eagle eye spot... 5:)
(From update of attachment 32015 [details])
Changing MIME type to text/plain. Dunno why it thought it was an octect
stream...
Ebuild works fine here, except the desktop-file (menu-entry) is gone...
(minor annoyance though, thanks for the ebuild!)
wfm too. don't know about the desktop-file though. Suspect it's not an issue
for xfce. :)
Mike: You are no inheriting eutils, so your patch is NEVER applied.
I fixed that and am testing the rest.
Created an attachment (id=38756) [details]
changes global install dirs to portage install image dirs
Just wanted to add that the ebuild works fine on my system too. I'd suggest
putting it into ~arch testing because there are no relevant blockers and
bluefish 0.13 has been out for really quite a while now. As for the desktop
file, it is indeed not being installed. I have attached an updated patch for
the makefile which fixes that. Basically what happened before was that before
installing the mime infos (including the desktop file) and stuff, an
if-condition checked if the destination dir exists. Now due the fact that the
destdir-gnome-dirs were poiting to our portage install image directory, none of
the gnome dirs existed. So what the new patch does is, if the variables
containing the path to their respective gnome dir are not empty (thus a path
has been found by configure), that dir is being created in our portage image
dir and the appropriate files are being installed. Ran several tests with it
and works flawlessly on my box. As far as I can tell, there are no missing
files left.
If there are still any problems left, let me know and I will have a look into
it.
Created an attachment (id=38757) [details]
changes global install dirs to portage install image dirs
The bluefish icon suffered from the same problem. Fixed in this new patch as
well. Now really nothing should be left missing. :-)
Latest ebuild and patch works for me
So when does it go into the portage tree? :-)
c'mon guys, get it in the tree now! ;)
Matthias, you seem to know your way around those problems (files in wrong
directory etc..), maybe if you have some time left, you could take a look at
the screem ebuilds?
Well that's a bit off-topic here but nevertheless, is there a bug report for
the screem ebuilds? Or what is wrong with them? I guess you better mail me in
private
or better file a bug report on this, if there doesn't already exist one and
give
me the bug number and as soon as I get around to it, I will have a look and
see, if I can figure something out.
BTW guys- HAPPY ALL HALLOW's EVE. *buuuuuuuuh, grins*
Just to stay on topic: I just wonder, why the blueflush ebuild is still not
being
updated in portage. I don't see any more problems with it. :-( Is this
currently
unmaintained?
Hanno, is anything holding this up?
Sorry for letting you wait so long, but now it's finally in the tree after some
cosmetic changes.
Created an attachment (id=46272) [details]
fixes bluefish-0.13 ebuild to use make install instead of einstall
Hanno, unfortunately one cosmetical change you made (replacing make install by
einstall) broke the installation process (see bug #74174). As the bluefish
makefile's are currently incompatible with einstall, we have to use make
install with DESTDIR set. Could you please fix that in cvs as it is a rather
huge ebuild bug, making a successful emerge of bluefish currently impossible.
Thanks a lot in advance.
