Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 472930

Summary: net-im/gajim should have gnome-keyring USE flag
Product: Gentoo Linux Reporter: Aline Freitas <aline>
Component: Current packagesAssignee: Justin Lecher (RETIRED) <jlec>
Status: RESOLVED FIXED    
Severity: normal CC: net-im, nikoli
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: gajim-0.15.3-r1.ebuild with gnome-keyring USE flag
gajim-0.15.4.ebuild with gnome-keyring use flag

Description Aline Freitas 2013-06-11 00:59:40 UTC
Created attachment 350720 [details]
gajim-0.15.3-r1.ebuild with gnome-keyring USE flag

netim/gajim needs a gnome-keyring USE flag to make it possible to install only gnome-keyring dependendies without the whole gnome environment. Gajim supports it so the changes in the ebuild are very simple. 

As an attachment follows my ebuid for gajim-0.15.3-r1. I did test it with different combinations for the flags "gnome" and "gnome-keyring" and is working smothly.

Thanks!
Comment 1 Justin Lecher (RETIRED) gentoo-dev 2013-06-12 16:36:12 UTC
(In reply to Aline Freitas from comment #0)
> Created attachment 350720 [details]
> gajim-0.15.3-r1.ebuild with gnome-keyring USE flag

Please add a unified diff.
Comment 2 Aline Freitas 2013-06-12 19:49:37 UTC
Created attachment 350850 [details, diff]
gajim-0.15.4.ebuild with gnome-keyring use flag

Sure,

Here is the patch.
Comment 3 Justin Lecher (RETIRED) gentoo-dev 2013-06-12 20:00:22 UTC
looks good, I will trust you that it works. will commit tomorrow.
Comment 4 Aline Freitas 2013-06-13 00:52:12 UTC
Fantastic! Thank you!
Comment 5 Justin Lecher (RETIRED) gentoo-dev 2013-06-13 05:51:09 UTC
+  13 Jun 2013; Justin Lecher <jlec@gentoo.org> gajim-0.15.4.ebuild:
+  Make gnome-keyring support accessible with complete gnome desktop, #472930;
+  thanks Aline Freitas for patch
+
Comment 6 Nikoli 2013-06-13 12:00:39 UTC
Are you sure that 'gnome? ( gnome-keyring )"' is correct? Attached patch has 'gnome? ( gnome-keyring )"'
Comment 7 Justin Lecher (RETIRED) gentoo-dev 2013-06-13 12:18:55 UTC
(In reply to Nikoli from comment #6)
> Are you sure that 'gnome? ( gnome-keyring )"' is correct? Attached patch has
> 'gnome? ( gnome-keyring )"'

makes sense. What is wrong with this.
Comment 8 Nikoli 2013-06-13 13:10:09 UTC
Sorry, misread the patch: thought it has 'gnome-keyring? ( gnome )'.