Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 465108

Summary: media-tv/xbmc - make more addons optional
Product: Gentoo Linux Reporter: hal <laservader>
Component: Current packagesAssignee: Gentoo Xbox project <xbox>
Status: RESOLVED FIXED    
Severity: normal Keywords: PATCH
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: Remove unneeded addons
Added optional addons into an array

Description hal 2013-04-08 14:28:10 UTC
Created attachment 344844 [details, diff]
Remove unneeded addons

If one wants to build xbmc with USE="-goom -fishbmc -projectm -rsxs" it is still possible to select the addons in the visualization and screensaver sections resulting in a crash of xbmc in cases when one selects the specific addon and it gets activated.

I'd expect plugins to not appear in the GUI at all if I didn't built them.

Attached is a patch which removes these addons. Additionally I added some paths to addons which are made for Android, Windows and OS X.
Comment 1 SpanKY gentoo-dev 2013-04-08 19:48:25 UTC
Comment on attachment 344844 [details, diff]
Remove unneeded addons

create an array instead and do a single rm

local disabled_addons=(
  repository.pvr-{android,ios,osx{32,64},win32}.xbmc.org
  visualization.dxspectrum
)
use rsxs || disabled_addons+=( screensaver.rsxs.{euphoria,plasma,....}
rm -rf "${disabled_addons[@]/#/${ED}/usr/share/xbmc/addons/}"
Comment 2 hal 2013-04-08 20:39:28 UTC
Created attachment 344884 [details, diff]
Added optional addons into an array

Good hint, looks better now.
Comment 3 SpanKY gentoo-dev 2013-04-13 19:22:31 UTC
Patch by hal to punt unused addons
http://sources.gentoo.org/media-tv/xbmc/xbmc-9999.ebuild?r1=1.139&r2=1.140