Summary: | net-voip/homer does not respect CXX | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Agostino Sarubbo <ago> |
Component: | New packages | Assignee: | Marcel Pennewiß <gentoo> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | proxy-maint |
Priority: | Normal | Keywords: | InVCS, PATCH |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 243502 | ||
Attachments: |
Patch for 0.24.1-ebuild
Patch for 0.25-ebuild Patch for 9999-ebuild |
Description
Agostino Sarubbo
2013-03-01 09:40:27 UTC
If setting CXX="/usr/bin/x86_64-pc-linux-gnu-g++" in make.conf is set, buildsystem uses /usr/bin/x86_64-pc-linux-gnu-g++ instead of /usr/bin/c++. So, how can i reproduce your issue? (In reply to comment #1) > If setting CXX="/usr/bin/x86_64-pc-linux-gnu-g++" in make.conf is set, > buildsystem uses /usr/bin/x86_64-pc-linux-gnu-g++ instead of /usr/bin/c++. > > So, how can i reproduce your issue? CXX and CC should not be set in make.conf only CHOST should be. But this variables should be exported by ebuild at buildtime(if it's needed), through toolchain-funcs eclass... Created attachment 341506 [details, diff]
Patch for 0.24.1-ebuild
Created attachment 341508 [details, diff]
Patch for 0.25-ebuild
Created attachment 341510 [details, diff]
Patch for 9999-ebuild
(In reply to comment #2) > CXX and CC should not be set in make.conf only CHOST should be. > > But this variables should be exported by ebuild at buildtime(if it's > needed), through toolchain-funcs eclass... Thanks for the report and the comments. Patch attached should fix this issue. Reported upstream, maybe there's an fix in buildsystem in future releases. (In reply to comment #1) > If setting CXX="/usr/bin/x86_64-pc-linux-gnu-g++" in make.conf is set, > buildsystem uses /usr/bin/x86_64-pc-linux-gnu-g++ instead of /usr/bin/c++. > > So, how can i reproduce your issue? What you need to do is to make sure that the build system files do not hardcode "g++" to CXX anywhere. If you are having problems dealing with this, I can create a patch to demonstrate you how to deal with these problems in the future. (In reply to comment #6) > (In reply to comment #2) > > CXX and CC should not be set in make.conf only CHOST should be. > > > > But this variables should be exported by ebuild at buildtime(if it's > > needed), through toolchain-funcs eclass... > > Thanks for the report and the comments. Patch attached should fix this > issue. Reported upstream, maybe there's an fix in buildsystem in future > releases. The patches look good to me. Did they actually fix the problem though? Do you see your expanded gcc tuple in your build.log? (In reply to comment #8) > The patches look good to me. Did they actually fix the problem though? Do > you see your expanded gcc tuple in your build.log? Before Patch: -- Check for working CXX compiler: /usr/bin/c++ -- Check for working CXX compiler: /usr/bin/c++ -- works ... cd /var/tmp/portage/net-voip/homer-0.25/work/Homer-Conferencing-0.25/HomerBuild/Build/Default/HomerBase/libHomerBase && /usr/bin/c++ -DHomerBase_EXPORTS .../HBRandom.cpp After Patch: -- Check for working CXX compiler: /usr/bin/x86_64-pc-linux-gnu-g++ -- Check for working CXX compiler: /usr/bin/x86_64-pc-linux-gnu-g++ -- works ... cd /var/tmp/portage/net-voip/homer-0.25/work/Homer-Conferencing-0.25/HomerBuild/Build/Default/HomerBase/libHomerBase && /usr/bin/x86_64-pc-linux-gnu-g++ -DHomerBase_EXPORTS .../HBRandom.cpp + 17 Mar 2013; Markos Chandras <hwoarang@gentoo.org> homer-0.24.1.ebuild, + homer-0.25.ebuild, homer-9999.ebuild: + Respect CXX. Thanks to Marcel Pennewiß <gentoo@pennewiss.de>. Bug #459846 + |