Bug 459472

Summary:	net-analyzer/rrdtool-1.4.7: add graph use flag
Product:	Gentoo Linux	Reporter:	Bruno <bonbons>
Component:	Current packages	Assignee:	Gentoo Netmon project <netmon>
Status:	RESOLVED FIXED
Severity:	enhancement	CC:	andreis.vinogradovs
Priority:	Normal	Keywords:	PATCH
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	Patch to add graph use flag

Description Bruno 2013-02-27 09:50:33 UTC

Between rrdtool-1.4.5 and 1.4.7 a new configure option has been added to make the graphical rendering option optional (and thus the corresponding dependencies)

Please make that configure option available a use flag.

Reproducible: Always

Comment 1 Bruno 2013-02-27 09:53:24 UTC

Created attachment 340292 [details, diff]
Patch to add graph use flag

Comment 2 Sergey Popov gentoo-dev

2013-03-06 04:43:53 UTC

Patch is incomplete or i do not understand buildsystem logic. This part, for example:

AC_ARG_ENABLE(rrd_graph,AS_HELP_STRING([--disable-rrd_graph],[disable all rrd_graph functions]),
[enable_rrdcgi=no],[enable_rrd_graph=yes])

Is this correct?

Comment 3 Jeroen Roovers (RETIRED) gentoo-dev

2013-03-06 16:06:17 UTC

--- ChangeLog   2013-03-06 16:58:37.954625918 +0100
+++ ChangeLog.new       2013-03-06 17:03:51.269029360 +0100
@@ -2,6 +2,9 @@
 # Copyright 1999-2013 Gentoo Foundation; Distributed under the GPL v2
 # $Header: /var/cvsroot/gentoo-x86/net-analyzer/rrdtool/ChangeLog,v 1.243 2013/03/06 04:46:44 pinkbyte Exp $

+  06 Mar 2013; Jeroen Roovers <jer@gentoo.org> rrdtool-1.4.7-r2.ebuild:
+  Add USE=graph by Bruno (bug #459472).

Comment 4 Bruno 2013-03-06 22:46:19 UTC

(In reply to comment #2)
> Patch is incomplete or i do not understand buildsystem logic. This part, for
> example:
> 
> AC_ARG_ENABLE(rrd_graph,AS_HELP_STRING([--disable-rrd_graph],[disable all
> rrd_graph functions]),
> [enable_rrdcgi=no],[enable_rrd_graph=yes])
> 
> Is this correct?

Well, it makes sense that whenever rrd_graph support is disabled, rrdcgi can't be enabled.
As such yes the patch is not fully sufficient/complete as rrdcgi useflag should only have any (enabled) effect at all when graph useflag is enabled as well.

From re-reading the ebuild that means that the `if use !rrdcgi` of src_install should possibly be changed to `if use !rrdgraph || use !rrdcgi`.


One thing I didn't check is packages that depend on rrdtool. Those of them that really need the graphing support should probably be changed to depend on rrdtool[graph], or ewarn when graph useflag is unset.