Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 455158

Summary: net-print/hplip - python-r1 migration help required
Product: Gentoo Linux Reporter: Daniel Pielmeier <billie>
Component: Current packagesAssignee: Daniel Pielmeier <billie>
Status: RESOLVED FIXED    
Severity: enhancement CC: python
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: ebuild using python-r1 eclass
ebuild using python-r1 eclass

Description Daniel Pielmeier gentoo-dev 2013-02-02 15:09:13 UTC
Created attachment 337678 [details, diff]
ebuild using python-r1 eclass

I took a look at the new python eclasses and tried to convert hplip. Attached is a first draft but I think it needs more work.

Also hplip is kind of special maybe one of the other new eclasses suits better. It should only depend on python if the minimal use flag is not set. It requires python with use threads and xml. It installs python scripts in non standard directories. It currently only works with python-2. Maybe the symlinks to pythonscripts which are installed need special treatment.

net-print/cups, sys-apps/dbus/dbus, net-analyzer/net-snmp and dev-python/notify-python are not migrated to python-r1 so I guess they need to be converted before this ebuild can be put into the tree?
Comment 1 Mike Gilbert gentoo-dev 2013-02-02 15:29:30 UTC
Given that description, you probably want python-single-r1.

I can't quite tell how the ebuild works from the patch, but you seem to be on the right track.

I would not wait around for those other packages to be converted. Just make a note to review the deps next time you touch hplip.
Comment 2 Daniel Pielmeier gentoo-dev 2013-02-02 17:51:38 UTC
Created attachment 337692 [details, diff]
ebuild using python-r1 eclass

Further changes
- use python-single-r1
- call python-single-r1_pkg_setup
- use python_fix_shebang
- use python_export without specifying an implementation
- remove fdo_mime_desktop_database_update calls
Comment 3 Daniel Pielmeier gentoo-dev 2013-02-09 08:58:48 UTC
Committed. Thanks for your input.