Summary: | media-libs/freetype: please review/prepare a multilib-build conversion | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Michał Górny <mgorny> |
Component: | Current packages | Assignee: | Gentoo Fonts Team <fonts> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | CC: | amd64, j6yNRdsH5Fc3, rhill |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://bugs.gentoo.org/show_bug.cgi?id=458728 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | 454646, 457134 | ||
Bug Blocks: | 455066, 455074 | ||
Attachments: |
Working multilib ebuild
Diff against gx86 one Ebuild, r2 Diff for r2 |
Created attachment 337632 [details, diff]
Diff against gx86 one
I don't think this is quite ready for prime-time yet. Let's test this in x11 overlay for a while, and in the meantime see where the dev ML discussion is going. (In reply to comment #2) > I don't think this is quite ready for prime-time yet. Let's test this in x11 > overlay for a while, and in the meantime see where the dev ML discussion is > going. I agree. I am mostly asking for general/code feedback on non-X11 packages so that at least a few checkboxes could be crossed. It should be noted that it doesn't work on a clean system ;). Setting another includedir breaks freetype-config (and yes, we should finally remove it/replace with pkg-config), and that breaks fontconfig build. Ancient compatibility mess... Created attachment 337698 [details] Ebuild, r2 (now with work-around for bug 455114) Created attachment 337700 [details, diff]
Diff for r2
Since there's a few users of multilib-build in the tree, we'd like to proceed deploying X11 libraries from emul-linux-x86-xlibs to the tree. Since freetype is part of that set, I'd appreciate your +1/-1 ASAP so we would know whether to keep the two in emul-linux or convert as well. Committed. You broke USE=utils. * Building utils make -j10 V=1 X11_PATH=/usr/lib64 ../freetype-2.4.11/config.mk:25: ../freetype-2.4.11/builds/unix/unix-def.mk: No such file or directory ../freetype-2.4.11/config.mk:26: ../freetype-2.4.11/builds/unix/unix-cc.mk: No such file or directory make: *** No rule to make target `../freetype-2.4.11/builds/unix/unix-cc.mk'. Stop. (In reply to comment #9) > You broke USE=utils. Oh, I'm sorry. I won't be able to fix it in next ~8 hours, so I'll package.mask the new versions for a while. Took me a while but fixed them finally. I've also opened a bug upstream [1] asking them to make it easier, or at least a bit more consistent. [1]:https://savannah.nongnu.org/bugs/?38412 (In reply to comment #7) > Since there's a few users of multilib-build in the tree, we'd like to > proceed deploying X11 libraries from emul-linux-x86-xlibs to the tree. Since > freetype is part of that set, I'd appreciate your +1/-1 ASAP so we would > know whether to keep the two in emul-linux or convert as well. You already had my -1 in comment #2. You pushed it through regardless, with ack by lu_zero who hasn't touched the package in 8 years. Since you broke a lot of packages doing so, as I feared, I have masked your ebuild. But I still am of the opinion that this should be developed and tested in an overlay instead of the tree. Before considering unmasking this, we need to decide as a developer community that this is indeed the way we want to go. As I see it now, it has its problems. *** Bug 487472 has been marked as a duplicate of this bug. *** |
Created attachment 337630 [details] Working multilib ebuild As media-libs/freetype is a part of emul-linux-x86-xlibs, I have prepared a conversion of it along with the X11 packages. I will attach a complete ebuild and a diff. Functional changes: 1) includes are installed to libdir. This was necessary to split the ABI-dependant configs (bug 254646) but it won't hurt packages using pkg-config; 2) removed epunt_cxx (a no-op here), 3) added a blocker on current emul-linux-x86-xlibs versions (to fix collisions), 4) converted the package to autotools-multilib. I know that Samuli is autotools-* eclass hater, so he'd probably want to reinvent all the wheels. Feel free to do so.