| Summary: | x11-libs/pixman add configure flag and libpng dependency for tests | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | James Le Cuirot <chewi> |
| Component: | [OLD] Library | Assignee: | Matt Turner <mattst88> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | x11 |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
pixman-png.patch
pixman-png.patch pixman-png.patch |
||
Nah. It's only used by tests. $ grep -r HAVE_LIBPNG * |grep -v Makefile.in config.h.in:#undef HAVE_LIBPNG configure:HAVE_LIBPNG configure:$as_echo "#define HAVE_LIBPNG 1" >>confdefs.h configure.ac: AC_DEFINE([HAVE_LIBPNG], [1], [Whether we have libpng]) configure.ac:AC_SUBST(HAVE_LIBPNG) test/utils.c:#ifdef HAVE_LIBPNG test/utils.c:#ifdef HAVE_LIBPNG As you can see, it's only used for tests -- maybe the maintainers want test? ( media-libs/libpng:0 ) and $(use_enable test libpng) Created attachment 336470 [details, diff]
pixman-png.patch
Okay, we at least need what you suggest or --disable-libpng because this broke my cross-compile. Here's a new patch.
Created attachment 336472 [details, diff]
pixman-png.patch
Oops, missed the SLOT. I realise its importance here.
There's no real point for this. In 0.28 libpng is used only in a single function of a *test* program, that doesn't seem to be called anyway. What's more, the function seems useful for interactive tests only. Okay, but we should as least add --disable-libpng because it still tries to build the test and fails if libpng is in / but not in ${ROOT}.
Done. Thanks. |
Created attachment 336468 [details, diff] pixman-png.patch ./configure has an --enable-libpng option and this hasn't been added to the ebuild. Please see the attached patch.