Summary: | dev-python/ws4py: uses unittest2 in py2.7 & py3.2+ | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Michał Górny <mgorny> |
Component: | Current packages | Assignee: | SpanKY <vapier> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | pacho, python |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | https://github.com/Lawouach/WebSocket-for-Python/issues/106 | ||
See Also: | https://bugs.gentoo.org/show_bug.cgi?id=450638 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | 487804 | ||
Bug Blocks: | 450616 |
Description
Michał Górny
2013-01-06 19:54:43 UTC
yes ditto. There's also 1 test that fails under 3.2 See See Also: It's routine to make if (<=py2.6 or =py3.1) them import unittest2, I've already done it somewhere recently, but I shall hold at for a fix to the test fail and do the 2 in 1, if that's ok with you, y mgorny on 2nd. thoughts, is this a case of attempting to fix something that's not really broken? You could import sys if sys.version_info[:2] == (2, 7) or sys.version_info[:3] == (3,2); test_suite='unittest.collector' else: test_suite='unittest2.collector' in setup.py, then you have to add DISTUTILS_USE_SEPARATE_SOURCE_DIRECTORIES="1" in the regular distutils to ensure a setup.py to match either of the 2. else similar for each instance of "import unittest" in test/test_*.py, then send it upstream, than await official acceptance, when it currently just works, Whether using distutils or distutils-r1, all this to substitute something that already does it all. And my second thought would be that the 'collector' submodule is setuptools-specific and it is found only in unittest2. So it's not something we can or should try to upstream. However, I see this as an unnecessary dep on a Gentoo system. My goal would be to fix packages so that modern py2.7/3.2 system would run without unittest2 installed at all. Considering that the 'collector' submodule is setuptools-specific, probably easiest way would be to run the test discovery directly. However, this requires us to make python_test() aware of which Python versions need unittest2... I wonder if we could install some kind of helper file in the virtual. ah right; getting there.... + 24 Feb 2014; Patrick Lauer <patrick@gentoo.org> +ws4py-0.3.2.ebuild: + Bump #487804 #450658 |