| Summary: | app-misc/goobook-1.4 ebuild problems | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Mike Gilbert <floppym> |
| Component: | New packages | Assignee: | Fabiano Francesconi <fabiano.francesconi> |
| Status: | RESOLVED UPSTREAM | ||
| Severity: | normal | CC: | hyedad, proxy-maint, python |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
Patch to goobook-1.4 for >=hcs-utils-1.3
Patch to goobook-1.4 ebuild Fixed DEPEND as well as RDEPEND for setuptools/PYTHON_DEPS. |
||
Created attachment 352766 [details, diff]
Patch to goobook-1.4 for >=hcs-utils-1.3
I've written a patch for goobook to fix the dependency on hcs-utils-1.1.1, instead depending on >=1.3 (tested with 1.3 and 1.4_rc5), and have a fixed version of the ebuild (ported to new python eclasses) to go with it.
Created attachment 352768 [details, diff]
Patch to goobook-1.4 ebuild
Created attachment 352802 [details, diff]
Fixed DEPEND as well as RDEPEND for setuptools/PYTHON_DEPS.
(In reply to Justin J. Snelgrove from comment #1) > Created attachment 352766 [details, diff] [details, diff] Thanks for the patch. Please report it upstream [1] and post a reference here. [1] http://code.google.com/p/goobook/issues/list +*goobook-1.4-r1 (08 Jul 2013) + + 08 Jul 2013; Michael Weber <xmw@gentoo.org> + +files/goobook-1.4-hcs-utils-1.3.patch, +goobook-1.4-r1.ebuild: + Ebuild update and patch by Justin J. Snelgrove (bug 449916), slightly modified + by me. + Thanks for reminding me, I'd forgotten to do that. It's upstream here: http://code.google.com/p/goobook/issues/detail?id=39 |
I noticed this package after removing dev-python/hcs-utils-1.1.1, which this package depends on specifically. In reviewing the ebuild, I notice a number of problems: 1. RDEPEND on =dev-python/hcs-utils-1.1.1 This is unacceptable long-term. Please patch setup.py to have a >= dependency and/or fix it upstream. 2. setup.py has argparse in install_requires for python2.7 where there this module is bundled in the standard library. This causes a runtime failure. Traceback (most recent call last): File "/usr/bin/goobook-2.7", line 5, in <module> from pkg_resources import load_entry_point File "/usr/lib64/python2.7/site-packages/pkg_resources.py", line 2803, in <module> working_set.require(__requires__) File "/usr/lib64/python2.7/site-packages/pkg_resources.py", line 697, in require needed = self.resolve(parse_requirements(requirements)) File "/usr/lib64/python2.7/site-packages/pkg_resources.py", line 595, in resolve raise DistributionNotFound(req) pkg_resources.DistributionNotFound: argparse>=1.1 3. Missing RDEPEND on dev-python/keyring. 4. Missing DEPEND and RDEPEND on dev-python/setuptools.