Bug 44809 - scummvm-0.6.0.ebuild (update)
Bug#: 44809 Product:  Gentoo Linux Version: unspecified Platform: All
OS/Version: Linux Status: RESOLVED Severity: enhancement Priority: P2
Resolution: FIXED Assigned To: games@gentoo.org Reported By: stephan.schiffel@gmx.de
Component: Games
URL: 
Summary: scummvm-0.6.0.ebuild (update)
Keywords:  
Status Whiteboard: 
Opened: 2004-03-15 23:13 0000
Description:   Opened: 2004-03-15 23:13 0000 
Hi!

ScummVM 0.6.0, the famous interpreter for SCUMM-games and some others, was released today. Here is an ebuild for it, which has also some other improvements:
I don't know the policy for new USE_EXPANDs, but I have added one:
ENGINES - contains the engines to be built (if empty or undefined all engines get installed), possible values are described in the ebuild

If that is not a good solution then it could also be done by local useflags.

other changes:
- now uses the "flac" use flag and has media-libs/flac as dependency
- changed dependencies to state minimal versions (found in the configure script)
- now uses the "debug" use flag



Reproducible: Always
Steps to Reproduce:
1.
2.
3.

------- Comment #1 From Stephan Schiffel 2004-03-15 23:15:24 0000 ------- 
Created an attachment (id=27439) [details]
ebuild

------- Comment #2 From Mr. Bones. 2004-03-15 23:47:06 0000 ------- 
Where do you see that configure supports flac?

------- Comment #3 From Stephan Schiffel 2004-03-15 23:55:24 0000 ------- 
Sorry, my fault. It was in the daily snapshot yesterday, but obviously it has
not made it in the release.

------- Comment #4 From Stephan Schiffel 2004-03-15 23:57:07 0000 ------- 
Created an attachment (id=27442) [details]
ebuild

removed "flac" use flag from ebuild

------- Comment #5 From Spider (RETIRED) 2004-03-15 23:57:25 0000 ------- 
a hint would be to use "use_enable " for those things instead of the
if-statements

confstr="`use_enable flac` `use_enable zlib` `use_enable debug` `use_enable
mad` `use_enable oggvorbis vorbis`"

------- Comment #6 From Stephan Schiffel 2004-03-16 00:24:59 0000 ------- 
Created an attachment (id=27446) [details]
improved ebuild

I made use of "use_enable" as Spider proposed.

What about the USE_EXPAND, is this ok?

------- Comment #7 From Mr. Bones. 2004-03-16 00:43:32 0000 ------- 
I think all the engines should just be built-in.  If scummvm had broader
application, it would make sense to make the configuration more fine-grained.
It's not going to change the size of the executable by much to just
put all the engines in.  If there's a big demand for it later we can revisit
it.

------- Comment #8 From Stephan Schiffel 2004-03-16 01:00:53 0000 ------- 
Created an attachment (id=27448) [details]
improved ebuild

removed the USE_EXPAND and changed the test of "debug" use flag back to old
"if" solution because there is no "--enable-debug" option.

------- Comment #9 From Spider (RETIRED) 2004-03-16 01:13:30 0000 ------- 
btw... the use of src_unpack here is redundant. You just duplicate defaults
there.

(oops, missed that in my first lookover)

------- Comment #10 From Stephan Schiffel 2004-03-16 01:18:18 0000 ------- 
Created an attachment (id=27449) [details]
ebuild

redundant src_unpack removed

------- Comment #11 From Mr. Bones. 2004-03-16 01:56:03 0000 ------- 
Bumped the version in CVS.  Thanks for the bug report and ebuild.

------- Comment #12 From Boris 2004-03-16 05:11:43 0000 ------- 
A small addition:
According to the README [1] libmpeg2 in version 0.4 or later is preferable for scummvm. So when libmpeg2-0.4.0 bumps to stable, the depend could be set to this.

[1] http://cvs.sourceforge.net/viewcvs.py/scummvm/scummvm/README?rev=release-0-6-0