Bug 447570

Summary:	sys-apps/portage: repoman should warn when 'USE defaults' are used on IUSE_IMPLICIT
Product:	Portage Development	Reporter:	Michał Górny <mgorny>
Component:	Repoman	Assignee:	Portage team <dev-portage>
Status:	RESOLVED WONTFIX
Severity:	enhancement	CC:	sera
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://bugs.gentoo.org/show_bug.cgi?id=447524 https://bugs.gentoo.org/show_bug.cgi?id=442830 https://bugs.gentoo.org/show_bug.cgi?id=525356
Whiteboard:
Package list:		Runtime testing required:	---

Description Michał Górny archtester

2012-12-17 10:25:07 UTC

Since IUSE_IMPLICIT is awfully stupid in EAPI=4, I think it would be really useful if repoman warned when someone tries to use '(-)' or '(+)' USE default on package with such a flag.

The IUSE_IMPLICIT rules make the flags implicitly available in the ebuild even if they're not declared by it. Therefore, USE defaults are meaningless and mostly result in broken ebuilds/eclasses being committed to the tree. By 'broken', I mean 'broken when used with Paludis'.

Comment 1 Zac Medico gentoo-dev

2012-12-17 18:57:29 UTC

To clarify, IUSE_IMPLICIT in this context means USE_EXPAND flags in EAPI 4 and earlier, right?

Comment 2 Michał Górny archtester

2012-12-17 19:10:01 UTC

(In reply to comment #1)
> To clarify, IUSE_IMPLICIT in this context means USE_EXPAND flags in EAPI 4
> and earlier, right?

In my particular mistake, yes. But I think the check could be generalized to anything PMS puts in IUSE_IMPLICIT since the USE defaults are meaningless there as well.

Comment 3 Zac Medico gentoo-dev

2012-12-17 19:22:24 UTC

Okay, that makes sense. For EAPI 5, it's not just IUSE_IMPLICIT, but also other profile variables like USE_EXPAND_IMPLICIT and USE_EXPAND_VALUES_*.

Comment 4 Sam James archtester

2022-07-12 03:18:17 UTC

repoman support has been removed per bug 835013.

Please file a new bug (or, I suppose, reopen this one) if you feel this check is still applicable to pkgcheck and doesn't already exist.