Bug 44705 - cromwell (new package)
|
Bug#:
44705
|
Product: Gentoo Linux
|
Version: unspecified
|
Platform: All
|
|
OS/Version: All
|
Status: RESOLVED
|
Severity: enhancement
|
Priority: P2
|
|
Resolution: FIXED
|
Assigned To: vapier@gentoo.org
|
Reported By: chrb@gentoo.org
|
|
Component: Ebuilds
|
|
|
URL:
|
|
Summary: cromwell (new package)
|
|
Keywords:
|
|
Status Whiteboard:
|
|
Opened: 2004-03-14 15:20 0000
|
2 new ebuilds for cromwell xbox bios; one cvs and one binary release (no source
releases are available).
problems with the ebuild:
(1) always use tabs for indentation; a 'Gentoo tab' is 4 spaces ... src_install currently uses spaces and there are 8 of em ;)
(2) you should almost never use `install` in src_install() since the Gentoo commands can do what needs to be done
(3) why install into /opt/${P} when this should be installed into /boot/ ?
(4) you set RESTRICT and dont worry about previous value (RESTRICT="nostrip")
Created an attachment (id=31951) [details]
sys-boot/cromwell/cromwell-2.30_p20040518.ebuild
I've fixed those problems, 4) was not actually true but I have a query - would
it have mattered? Many ebuilds do RESTRICT="x".